196217 - remove nsVoidArray::ElementAt() check for an upper bounds

Status: RESOLVED INCOMPLETE

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

nsVoidArray::ElementAt() checks for an upper bound.  This test should only be in
debug build.  Consider the following:

nsVoidArray a;
...
int max = a.Count();
for (int index = 0; index < max; index++)
{
  a.ElementAt(index);
}

I don't see any requirement of addtional bounds checking within ElementAt(). If
consumers require bounds checking in this API, there is an alternative
SafeElementAt which is availabe.

Maybe there are still customers depending on something like:

while(a.ElemenentAt(i++))

However I haven't seen any of the assertions that already exist in that code.

Comment 1

[Doug Turner (:dougt)]

Attachment: removes bounds check

Comment 2

[Alec Flett]

Comment on attachment 116457 [details] [diff] [review]
removes bounds check

r/sr=alecf

Comment 3

[Doug Turner (:dougt)]

we should shoot for the 1.5a train.

Comment 4

[Mikael Parknert]

Should this be checked in?

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think we should WONTFIX this. Removing the boundscheck would surely cause
crashers in clients. It'd be better to deprecate ElementAt and move consumers
over to SafeElementAt and FastElementAt