Closed Bug 1962228 Opened 1 month ago Closed 21 days ago

Add telemetry for pref changes for smart tab groups

Categories

(Firefox :: Tabbed Browser, task)

Product:
Firefox
Component:
Tabbed Browser
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
140 Branch
Tracking Flags:
Tracking Status
firefox139 + fixed
firefox140 --- fixed

People

(Reporter: vbaungally, Assigned: vbaungally)

References

(Blocks 1 open bug)

Details

(Whiteboard: [genai])

Attachments

(2 files, 1 obsolete file)

Bug 1962228 - Add Telemetry for Pref Changes for Smart Tab Groups. r?rrando,ngrato
48 bytes, text/x-phabricator-request
Details | Review
Bug 1962228 - Add Telemetry for Pref Changes for Smart Tab Groups. r?rrando,ngrato
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review

We currently have telemetry in about:preferences but only whether a user clicked on the preferences. This work would add an extra field to tell if the preferences was enabled / disabled.

Attachment #9480666 - Attachment is obsolete: true
Summary: Add enabled/ disabled telemetry in about:preferences for smart tab groups → Add telemetry for pref changes for smart tab groups

Per DS request, we should record both metrics and events when the prefs change.

[Tracking Requested - why for this release]: add telemetry so we know how many users are using / have enabled or disabled this feature in 139

status-firefox139: --- → affected
tracking-firefox139: --- → ?
Blocks: 1939611
See Also: → https://mozilla-hub.atlassian.net/browse/GENAI-1073
Whiteboard: [genai]
Pushed by vbaungally@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e8dd9fddfab Add Telemetry for Pref Changes for Smart Tab Groups. r=rrando,tabbrowser-reviewers,sthompson

https://hg.mozilla.org/mozilla-central/rev/2e8dd9fddfab

Status: NEW → RESOLVED
Closed: 21 days ago
status-firefox140: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
Attachment #9485063 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined: None but we won't be able to track how many users have enabled / disabled the feature, which is one of our key metrics to roll this out.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: Start a new build and then from the console type Glean.tabgroup.smartTabEnabled.testGetValue(). This should show true or false.
  • Risk associated with taking this patch: Shouldn't be any, we're just adding telemetry.
  • Explanation of risk level: We have test coverage here, so this should hopefully be ok.
  • String changes made/needed: No
  • Is Android affected?: no
Attachment #9485063 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: