Closed
Bug 1962394
Opened 20 days ago
Closed 8 days ago
Remove static mocking of Toast class in SecretDebugMenuTriggerTest
Categories
(Firefox for Android :: General, task)
Tracking
()
RESOLVED
FIXED
140 Branch
| Tracking | Status | |
|---|---|---|
| firefox140 | --- | fixed |
People
(Reporter: mcarare, Assigned: mcarare)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][group6])
Attachments
(1 file, 1 obsolete file)
|
Bug 1962394 - Refactor SecretDebugMenuTrigger and AboutFragment to better separate responsibilities.
48 bytes,
text/x-phabricator-request
|
Details | Review |
We shoud refactor the SecretDebugMenuTrigger code in order to remove the need for using static mocking of the android widget Toast class.
For this purpose we should simplify the testing by also separating the UI wiring code from the secret settings enabling. (the primary responsibility of SecretDebugMenuTrigger component)
|
Assignee | |
Updated•20 days ago
|
Component: Tooling → General
|
||
Updated•20 days ago
|
|
|
Assignee | |
Comment 1•20 days ago
|
||
- Extract logo click logic into
SecretDebugMenuTrigger. - Move UI wiring setup to
AboutFragment.
|
|
Assignee | |
Comment 2•12 days ago
|
||
|
||
Updated•12 days ago
|
Attachment #9480917 -
Attachment is obsolete: true
Pushed by mcarare@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c826ca1cf378
Refactor SecretDebugMenuTrigger and AboutFragment to better separate responsibilities. r=jonalmeida
|
||
Comment 4•8 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 days ago
status-firefox140:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•