1962445 - Remove static mocking of org.mozilla.fenix.ext.ActivityKt used for openSetDefaultBrowserOption extension method.

Status: RESOLVED FIXED

(Firefox for Android :: General, task, P1)

Description

[Mihai Adrian Carare [:mcarare]]

There are 2 tests that use static mocking in order to mock the openSetDefaultBrowserOption extension method ( HomeActivityTest and DefaultSessionControlControllerTest) .
Since the behavior is difficult to test ( among others is requires accessing system services) we should use an instance method in HomeActivity to indirectly access the extension method and verify that method is called instead of the extension method.

Comment 1

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1962445 - Refactor access to openSetDefaultBrowserOption and remove static mocking of Activity class.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dffe5727c97
Refactor access to openSetDefaultBrowserOption and remove static mocking of Activity class. r=android-reviewers,jonalmeida

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4dffe5727c97