1962580 - Crash in [@ nsFaviconService::GetFaviconForPage]

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P1)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/f4014a0e-dd98-47d2-99d9-7bcf20250424

MOZ_CRASH Reason:

MozPromise::ThenValue created from 'GetFaviconForPage' destroyed without being either disconnected, resolved, or rejected (dispatchRv: not dispatched)

Top 10 frames:

0  XUL  MOZ_CrashSequence(void*, long)  mfbt/Assertions.h:253
0  XUL  MOZ_Crash(char const*, int, char const*)  mfbt/Assertions.h:381
0  XUL  mozilla::MozPromise<nsCOMPtr<nsIFavicon>, nsresult, true>::ThenValueBase::Ass...  xpcom/threads/MozPromise.h:527
1  XUL  mozilla::MozPromise<nsCOMPtr<nsIFavicon>, nsresult, true>::AssertIsDead()  xpcom/threads/MozPromise.h:1253
2  XUL  mozilla::MozPromise<nsCOMPtr<nsIFavicon>, nsresult, true>::~MozPromise()  xpcom/threads/MozPromise.h:1301
3  XUL  mozilla::MozPromise<nsCOMPtr<nsIFavicon>, nsresult, true>::Private::~Private()  xpcom/threads/MozPromise.h:257
3  XUL  mozilla::MozPromise<nsCOMPtr<nsIFavicon>, nsresult, true>::Private::~Private()  xpcom/threads/MozPromise.h:257
3  XUL  mozilla::MozPromise<nsCOMPtr<nsIFavicon>, nsresult, true>::Private::~Private()  xpcom/threads/MozPromise.h:257
4  XUL  mozilla::MozPromiseRefcountable::Release()  xpcom/threads/MozPromise.h:152
4  XUL  mozilla::RefPtrTraits<mozilla::MozPromise<nsCOMPtr<nsIFavicon>, nsresult, tru...  mfbt/RefPtr.h:49

Similar to bug 1962575, but not quite the same error message so I'll leave it separate.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:daisuke, since you are the author of the regressor, bug 1915762, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1915762

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 20 desktop browser crashes on beta

:mak, could you consider increasing the severity of this top-crash bug?

For more information, please visit BugBot documentation.

Comment 4

[Marco Bonardo [:mak]]

I think this was addessed by bug 1962575, leaving it open for now to ensure signatures disappear.