1962763 - For SERP telemetry, change requirements for the form parameter when cookies are also set

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

Currently for SERP pages where cookies are used to detect follow-on searches, we need to change how the algorithm works.

We should drop the reliance on the extraCodeParamName. Then:

• If the codeParamName is present, use the value to determine tagged vs organic
• Otherwise, if the cookie is present, use the value from there to determine tagged vs organic.
• Otherwise, it is an organic search.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1962763 - Update search-telemetry-v2 extraCode details to not require a parameter to be set. r?jteow!

Comment 2

[Mark Banner (:standard8)]

Due to the way the code is written, we can make extraCodeParamName an empty string, and we'll end up doing the right thing.

The Android code isn't doing the same checks here, but I'll file a separate bug to get that fixed - their telemetry is slightly broken anyway due to other issues.

Comment 3

[Mark Banner (:standard8)]

This is now on remote settings stage (approved). Please can QA give it a test?

Comment 4

[Cristian Baica [:cbaica], Release Desktop QA]

Testing is on hold until uplifts from bug 1962757 land on beta and esr.

Comment 5

[Cristian Baica [:cbaica], Release Desktop QA]

Verification is complete using RS - Stage as specified. The "tagged-follow-on:MOZI" value is now displayed whenever cookies are saved for bing and "organic:none" value whenever no cookies are existent or the pc is different.
The results can be viewed here.

Please note that RC builds were not covered because of bug 1962757.

Fix is ready for PROD push from QA perspective.

Comment 6

[Mark Banner (:standard8)]

This has now shipped to production as of about 14:10 UTC today.