Closed Bug 1962878 Opened 24 days ago Closed 21 days ago

Adjust reftests to avoid fraction inline-size of grid containers

Categories

(Core :: Layout: Grid, task)

task

Tracking

()

RESOLVED FIXED
140 Branch
Tracking Status
firefox140 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

(Whiteboard: [grid-percentages:m1])

Attachments

(1 file)

While updating some grid reftests in our framework, I noticed that a few grid containers end up with fractional inline sizes, which don’t match the reference files. Although these tests pass on CI, they consistently fail on my local machine. I plan to tweak the test cases to eliminate fractional inline sizes and ensure those reftests pass consistently.

These reftests currently pass on CI but fail locally for me due to subpixel
inline-sizes on grid containers. This patch tweaks the grid items' height or
max-height so that the container's inline-size remains an integer.

For example, in grid-auto-min-sizing-transferred-size-004.html (Test 8), we
set the image grid item's block-size to 12 px (half of its intrinsic 24px
block-size) so it contributes exactly half its intrinsic inline-size, avoiding
fractional values. Similar adjustments are made in the other reftests.

Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Whiteboard: [grid-percentages:triage]
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/48a240ee9d86 Adjust reftests to avoid fraction inline-size of grid containers. r=dholbert
Status: ASSIGNED → RESOLVED
Closed: 21 days ago
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
Whiteboard: [grid-percentages:triage] → [grid-percentages:m1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: