1963128 - [ews] Error during sync when creating a folder that already exists

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Eleanor Dicharry]

When processing a message from EWS to create a folder that already exists, we get a debug assertion failure caused by an unrecognized error code.

Internally, the code that creates the folder in the local store to return NS_MSG_FOLDER_EXISTS. We use NS_ENSURE_SUCCESS to check return values in the current create folder implementation on the EwsIncomingServer side. However, it looks like NS_ENSURE_SUCCESS ends up triggering a debug assertion when it get NS_MSG_FOLDER_EXISTS because NS_MSG_FOLDER_EXISTS isn't a recognized error code from the autogenerated ErrorList.h.

Comment 1

[Eleanor Dicharry]

Steps to reproduce:

1. Use a build with debug assertions enabled.
2. Create a folder on an EWS server using Thunderbird.
3. Trigger a sync and note the crash.

Comment 2

[Eleanor Dicharry]

Attachment: Bug 1963128 - Check for existing EWS ID prior to folder creation. r=babolivier,#thunderbird-back-end-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3ada9c3b58ff
Check for existing EWS ID prior to folder creation.r=babolivier