1963136 - Incorrect "Revision has unresolved comments" message

Status: RESOLVED INVALID

(Conduit :: Lando, defect)

Description

[Steve Fink [:sfink] [:s:]]

It is very possible that I'm just missing something, but right now when I preview the landing for D244854 it tells me that both D244854 and D244853 have unresolved comments and I don't see any. I don't think this is bug 1833121 because I don't think I've changed the set of files touched, though it's possible I'm wrong? At any rate, I can't see any remaining comments on either D244854 or D244853. They've both gone through a lot of versions, though.

(It would be really nice if the lando warning link went to some magic page that listed out all unresolved comments, regardless of which version they belong to.)

Comment 1

[Connor Sheehan [:sheehan]]

I can see a "Not Done" comment from jonco on both revisions. On D244853 I can see the unresolved comment on js/src/vm/StringType.h, and on D244854 I can see the unresolved comment on js/src/gc/Tenuring.cpp.

Annoyingly I don't think Phab supports linking to comments.

Comment 2

[Steve Fink [:sfink] [:s:]]

Wait, you're right. I could only find it by clicking through the versions one by one. Except... now when I go to the main page for D244854, it shows up immediately.

Did I really completely miss it before? Totally possible.

Oh, but D244853 shows it still. If I go to the main page, I don't see any comments listed in the header when I scroll down through the diffs. If I click on "Show older changes", same thing. If I click specifically on Diff 4, then I see "9/10 Comments", which is enough to show me the one not marked Done. But how did you find it?

Oh! When it's not showing me any comments, I can click on the ☰ overflow menu thing, and it has an option to "List inline comments" that I've never found before. Aha! That's how I can find them.

Ok, no bug here, I was holding it wrong. But I still feel like I must be missing some more mainstream way of stumbling across the comment.

Comment 3

[Steve Fink [:sfink] [:s:]]

Oh, and clicking on the unDone comment doesn't actually show me the comment. I have to (1) remember the Diff id that it lists, (2) find it in the list of diffs and click on it, then (3) scroll down and use the "9/10 Comments" header to actually go to it.