1963371 - Unique groupId for internal speaker with RFPTarget::MediaDevices is unusual

Status: ASSIGNED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

It's unusual for the default ("Internal") speaker and microphone to have different groupId.

STR:

1. In about:config, set privacy.resistFingerprinting = true
2. Open https://jan-ivar.github.io/dummy/enumerate.html
3. Click the Start Mic! button (and allow)
4. Click the Enumerate devices! button

Expected result (wo/privacy.resistFingerprinting or with a moden laptop in any other browser, modulo naming):

3 devices.
audioinput: Internal Microphone id=PjrPhB89CbU4WhFIvECQdXxMyTd6fJOydI/gTaBQTUQ= group=lTjdar1c/V5TmYuX40hzMt7kfmtTNv3OdptBe+l5gMg=
videoinput: id= group=
audiooutput: Internal Speaker id=26lHSLev+o9A4EErRvCzDyOLPH6kFcOvbLVTYGXvpa4= group=lTjdar1c/V5TmYuX40hzMt7kfmtTNv3OdptBe+l5gMg=

Actual result:

3 devices.
audioinput: Internal Microphone id=PjrPhB89CbU4WhFIvECQdXxMyTd6fJOydI/gTaBQTUQ= group=lTjdar1c/V5TmYuX40hzMt7kfmtTNv3OdptBe+l5gMg=
videoinput: id= group=
audiooutput: Internal Speaker id=26lHSLev+o9A4EErRvCzDyOLPH6kFcOvbLVTYGXvpa4= group=p81sB6f/S+anTUlxYWo+ZQQLpUWjyV6L/YZwdLHe4OY=

With https://github.com/w3c/mediacapture-output/pull/150 this no longer violates the spec, but stands out, at least on the platforms I've tested.

We discovered this in bug 1958963 where we decided to leave RFPTarget::MediaDevices untouched with the old Firefox behavior of only exposing speakers with the same groupId as a microphone. That filtering relies on the internal raw group id which in both cases is builtin-internal-mic|spk.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1912023

:fkilic, since you are the author of the regressor, bug 1912023, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Fatih Kilic [:fkilic]]

Hmm I think we need to make sure the group id is the same for speaker here https://searchfox.org/mozilla-central/rev/91cd9f3b8047176d84624ee2b8431e859f8d7bef/dom/media/MediaDevices.cpp#371. We can hardcode it to Fake Audio Group or move the creation to fake engine enumerate devices. I'll work on it.

Comment 3

[Fatih Kilic [:fkilic]]

Attachment: Bug 1963371 - Use the same group name for Audio input and output. r?jib