196340 - Change NS_REINTERPRET_CAST(nsIScriptContext*, JS_GetContextPrivate(cx)) to use Static Cast

Status: VERIFIED FIXED

(Core :: Security: CAPS, defect)

Description

[timeless]

found while reviewing bug 196241:
in bug 168316 comment 14, heikki wrote:
>>+    nsCOMPtr<nsIScriptContext> scriptContext =
>>+        NS_REINTERPRET_CAST(nsIScriptContext*, JS_GetContextPrivate(cx));
> Does this require reinterpret cast or would static cast do?

All other consumers (xpconnect, jsd, dom) uses static cast. At the present time
SeaMonkey only has one producer (dom).

Comment 1

[timeless]

Attachment: change cast from reinterpret to static

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 116562 [details] [diff] [review]
change cast from reinterpret to static

How did you manage to apply for double review and super review? :)

sr=heikki

Comment 3

[Mitchell Stoltz (not reading bugmail)]

Comment on attachment 116562 [details] [diff] [review]
change cast from reinterpret to static

r=mstoltz

Comment 4

[timeless]

checked in

Comment 5

[Mitchell Stoltz (not reading bugmail)]

V