1963471 - Move TranslationsMiddleware out of EngineMiddleware

Status: RESOLVED FIXED

(Firefox for Android :: Translations, task, P1)

Description

[Jonathan Almeida [:jonalmeida]]

In bug 1958042, we added flags that configure the TranslationsMiddleware. These get passed through to EngineMiddleware.create constructor.

Since translations is an optional engine feature, we can take it out of this core engine middleware list so that we don't build a pattern of passing flags through EngineMiddleware.

Comment 1

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 1963471 - Move TranslationsMiddleware out of EngineMiddleware list r=kaya,ohall

This is purely for code cleanup to avoid unnecessary patterns.

Comment 2

[Jonathan Almeida [:jonalmeida]]

https://treeherder.mozilla.org/jobs?repo=try&revision=3de97bf55807fe1aded240904433af7ded93e2c7

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ad750e74d19
Move TranslationsMiddleware out of EngineMiddleware list r=kaya,ohall,android-reviewers

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9ad750e74d19