1963477 - Enable fsmonitor/watchman during `./mach vcs-setup`

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement, P2)

Description

[Alex Hochheiden [:ahochheiden]]

Currently only the bootstrap.py script adds the watchman hook. The instructions we sent out for the git changeover were to do a raw git clone https://github.com/mozilla-firefox/firefox.git, so all the additional things done in the standalone bootstrap script were unintentionally circumvented.

While we're doing this, we can migrate away from watchman on Windows/macOS. The built-in fsmonitor on git version 2.37 or higher is better than using the watchman hook. As such, let's bump the minimum git version to 2.37, setup fsmonitor on Windows and macOS, and add the watchman hook for linux users in ./mach vcs-setup.

Comment 1

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1963477 - Bump MINIMUM_RECOMMENDED_GIT_VERSION to 2.37+ r?#build,sheehan

https://github.blog/open-source/git/highlights-from-git-2-37

The fsmonitor that's built-in for git 2.37+ on Windows/macOS is
superior to using watchman with a hook. As such, we should recommended
this as the minimum version, and automatically configure fsmonitor in a
subsequent patch.

Comment 2

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1963477 - Make the `MINIMUM_GIT_VERSION` a hard requirement in `bootstrap.py:configure_git` r?#build,sheehan

Comment 3

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1963477 - Remove `git` version check for `core.untrackedCache` setting r?#build,sheehan

This check is unnecessary now that the minimum required git is 2.37.

Comment 4

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1963477 - Add per-OS git filesystem performance config to `./mach vcs-setup` r?#build,sheehan

• fscache is only supported on Windows.
• The built-in fsmonitor is superior to the Watchman hook, but is only supported on Windows/macOS.
• Linux still requires watchman (and the sample hook script) to get fsmonitor-style speedups.

Comment 5

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1963477 - Remove `watchman` hook setup from standalone `bootstrap.py` script r?#build,sheehan

This is no longer necessary, as this is now handled entirely by ./mach vcs-setup.

Comment 6

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1963477 - Only do `git-cinnabar` checks on `git-cinnabar` repos r?#build,sheehan

Comment 7

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1963477 - Add logging output for `configure_git` r?#build,sheehan

• Minor renames/refactoring

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95fe04731cdb
Bump MINIMUM_RECOMMENDED_GIT_VERSION to 2.37+ r=sheehan
https://hg.mozilla.org/integration/autoland/rev/6f5c43099ee0
Make the `MINIMUM_GIT_VERSION` a hard requirement in `bootstrap.py:configure_git` r=sheehan
https://hg.mozilla.org/integration/autoland/rev/e72997c9d887
Remove `git` version check for `core.untrackedCache` setting r=sheehan
https://hg.mozilla.org/integration/autoland/rev/8df0e499afc4
Add per-OS git filesystem performance config to `./mach vcs-setup` r=sheehan
https://hg.mozilla.org/integration/autoland/rev/7c36158c954d
Remove `watchman` hook setup from standalone `bootstrap.py` script r=sheehan
https://hg.mozilla.org/integration/autoland/rev/44c752305a21
Only do `git-cinnabar` checks on `git-cinnabar` repos r=sheehan
https://hg.mozilla.org/integration/autoland/rev/9f42bb12acde
Add logging output for `configure_git` r=sheehan

Comment 9

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1963477 - Update text for `CONFIGURE_GIT` to remove the mention of `git-cinnabar` r?#build

Comment 10

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1963477 - Minor adjustments to `mozboot/bootstrap.py` regarding `git`/`git-cinnabar` r?#build

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/95fe04731cdb
https://hg.mozilla.org/mozilla-central/rev/6f5c43099ee0
https://hg.mozilla.org/mozilla-central/rev/e72997c9d887
https://hg.mozilla.org/mozilla-central/rev/8df0e499afc4
https://hg.mozilla.org/mozilla-central/rev/7c36158c954d
https://hg.mozilla.org/mozilla-central/rev/44c752305a21
https://hg.mozilla.org/mozilla-central/rev/9f42bb12acde

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9fbaaab98e2
Update text for `CONFIGURE_GIT` to remove the mention of `git-cinnabar` r=firefox-build-system-reviewers,glandium

Comment 13

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/f9fbaaab98e2

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d47729c846d
Minor adjustments to `mozboot/bootstrap.py` regarding `git`/`git-cinnabar` r=firefox-build-system-reviewers,glandium

Comment 15

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/6d47729c846d