Can't set value for the setting privacy.resistFingerprinting.letterboxing.vcenter in about:config since version 137.
Categories
(Core :: Privacy: Anti-Tracking, defect)
Tracking
()
People
(Reporter: 2ryf7r6yri4502gcsg6t, Unassigned)
Details
Attachments
(3 files)
My about:config preferences for letterboxing.
Steps to reproduce:
Set the values for privacy.resistFingerprinting, privacy.resistFingerprinting.letterboxing and privacy.resistFingerprinting.letterboxing.vcenter to true in about:config.
Actual results:
It creates a padding around the window; 'letterboxing' it. The letterboxed window is placed just below the url-bar.
Expected results:
Up to version 136.0.4, setting privacy.resistFingerprinting.letterboxing.vcenter to true aligned the letterboxed window to the middle. Since version 137, the letterboxed window always aligns to the top; no matter the setting.
|
||
Comment 1•20 days ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Privacy: Anti-Tracking' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
||
Comment 2•19 days ago
|
||
I'll ask Piero - but I don't think this pref ever existed in Firefox, I don't think it's been uplifted. It's not presently in tree in any form.
I'm unsure how the preference could have never existed. I've always set the same preferences and they've always worked for me. But not since version 137. I'm currently on version 138.0.1. For clarity; I've added some screenshot showing me setting the preferences and how the letterboxed window looks in version 136.0.4 vs 138.0.1.
|
||
Comment 7•18 days ago
•
|
||
I wonder if it is about bug 1556016?
FWIW running a git log search also suggests we never had vcenter pref, maybe we just defaulted to center? I don't know really.
Also you can set any pref and it will show up in about:config, doesn't matter if it is defined/used in any file. So, it could be that vcenter pref on Firefox was always noop and we always defaulted to center.
|
||
Comment 8•16 days ago
|
||
As far as I know, we added privacy.resistFingerprinting.letterboxing.vcenter to Tor Browser, but it has never been a Firefox thing.
For bug 1556016, I haven't included the "cosmetic" features, such as rounded corners, centering, etc...
I wanted to address that in a separate moment, but so far I haven't had time for it.
|
|
||
Comment 9•6 days ago
|
||
Yes, it was Bug 1556016 - I confirmed with mozregression that after that patch we stopped vertically centering the frame. I'm afraid this is working as intended.
|
||
Comment 10•5 days ago
|
||
Well, we could keep this open if pierov wants to repurpose it and uplift prefs, but not the UI, for remember window size, positioning, and letterboxing colors etc
|
|
||
Comment 11•5 days ago
|
||
(In reply to Thorin [:thorin] from comment #10)
Well, we could keep this open if pierov wants to repurpose it and uplift prefs, but not the UI, for remember window size, positioning, and letterboxing colors etc
I was thinking of using Bug 1594455.
Description
•