1963746 - There's two implementations of what to do when a message is marked as junk

Status: ASSIGNED

(MailNews Core :: General, task)

Description

[Geoff Lankow (:darktrojan)]

While trying to implement a simple button which marks a message as junk and performs the appropriate actions on it, I discovered there's two existing implementations: nsMsgDBView has PerformActionsOnJunkMsgs (which calls nsMsgDBView::DetermineActionsForJunkChange) and junkCommands.js has a function of the same name (calling determineActionsForJunkMsgs). The former has tests, but they could be better. The latter is not tested.

Not only that, but I think they're both overly complicated and would make more sense as a function on nsMsgDBFolder.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1963746 part 1 - Move junk handling code into nsMsgDBFolder. r=#thunderbird-back-end-reviewers

This consolidates most of the junk handling code into one place. In part two I'll change the
remaining implementation in nsMsgDBView to use this code too.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/853c96f5e4d8
part 1 - Move junk handling code into nsMsgDBFolder. r=mkmelin