1963847 - Use `ElementState::OPEN` in `Open()`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Comment 1

[Keith Cirkel [:keithamus]]

Attachment: Bug 1963847 - Use ElementState::OPEN in Open() over GetBoolAttr() r?#dom-core,smaug,emilio

See: https://phabricator.services.mozilla.com/D235504#inline-1362631

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47d8fdfd2af4
Use ElementState::OPEN in Open() over GetBoolAttr() r=smaug

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d36096b6128f
Revert "Bug 1963847 - Use ElementState::OPEN in Open() over GetBoolAttr() r=smaug" for asserting at dom/html/HTMLDialogElement.cpp:287

Comment 4

[Sandor Molnar[:smolnar]]

Backed out/reverted for causing bc assertion failures @ HTMLDialogElement.cpp

Push with failures

Failure log -> Assertion failure: GetBoolAttr(nsGkAtoms::open) == State().HasState(ElementState::OPEN), at /builds/worker/checkouts/gecko/dom/html/HTMLDialogElement.cpp

Comment 5

[Keith Cirkel [:keithamus]]

Thanks, this was a rebase error!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5ca4f97f7c7
Use ElementState::OPEN in Open() over GetBoolAttr() r=smaug

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c5ca4f97f7c7