1963990 - support links in browsing section are missing specific page

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Ed Lee :Mardak]

https://searchfox.org/mozilla-central/rev/7d73613454bfe426fdceb635b33cd3061a69def4/browser/components/preferences/widgets/setting-group/setting-group.mjs#45

probably wants to be supportLink.setAttribute("support-page", item.supportPage);

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1951141

:mstriemer, since you are the author of the regressor, bug 1951141, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1963990 - Add supportPage property to moz-support-link r?#recomp-reviewers

This fixes a bug where the support page for the Browsing section in
Settings was being set using the non-existent property and therefore not
being set at all.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb870bfba1ed
Add supportPage property to moz-support-link r=reusable-components-reviewers,tgiles

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fb870bfba1ed

Comment 5

[Donal Meehan [:dmeehan]]

:mstriemer does this need a beta uplift for Fx139?

Comment 6

[Mark Striemer [:mstriemer]]

Comment on attachment 9485176 [details]
Bug 1963990 - Add supportPage property to moz-support-link r?#recomp-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: SUMO links are broken in the Browsing section of Settings
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple change from a JS property to a DOM attribute
• String changes made/needed: No
• Is Android affected?: No

Comment 7

[Mark Striemer [:mstriemer]]

This should definitely be uplifted to beta in my opinion, a ride along for release wouldn't be a bad idea either.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/cd43fdd46c0d

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9485176 [details]
Bug 1963990 - Add supportPage property to moz-support-link r?#recomp-reviewers

Approved for 139.0b6

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9485176 [details]
Bug 1963990 - Add supportPage property to moz-support-link r?#recomp-reviewers

Approved for 138.0.3 dot release

Comment 11

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/577faaf8fd41