1964036 - Outdated styles are shown for Top Stories if `browser.newtabpage.activity-stream.discoverystream.enabled` is set to `false`

Status: NEW

(Firefox :: New Tab Page, defect, P3)

Description

[npypchenko]

If browser.newtabpage.activity-stream.discoverystream.enabled is turned off, the New Tab page looks very different to either default or Sections view (screenshot attached):

• The styles for both story cards and recent activity tiles are different, with underlining very prominent.
• The context menu button is a circle right on the edge of the card.
• Every single story is tagged as ":zap: Trending".
• The "Learn more" link below the cards is just one character and links to https://getpocket.com/explore/trending?src=fx_new_tab

Additionally, with this setting off, the Settings page adds a dropdown with a configurable number of rows of stories to display for "Recommended stories" (see screenshot), with a choice of 1-4 rows, max 12 stories. This is being removed with the code refactor in https://phabricator.services.mozilla.com/D243042.

I have looked through the commits and it appears this setting was added in 2019: https://bugzilla.mozilla.org/show_bug.cgi?id=1573930. I'm not sure if this setting can/should be removed, but my vote is definitely for the outdated styling to be pruned from the repository and the code to default to Discovery Stream styles.

Comment 1

[npypchenko]

Attachment: recommendations-and-recent-activity-with-discoverystream-off.png