1964053 - [wpt-sync] Sync PR 52285 - [Viewport Segments] Fix WPT tests not working on wpt.fyi

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52285 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52285
Details from upstream follow.

Menard, Alexis <[e-mail]> wrote:

[Viewport Segments] Fix WPT tests not working on wpt.fyi

It turns out that the runner may have a viewport with dimensions which
will not return an integer if divided by 2 (to put the display feature
in the middle). set_display_features expect an integer so let's make sure we give it one. Also make sure we allow for rounding errors when checking the values of the segments.

Bug: 40137084
Change-Id: I713be16200f78cdca15e80d0397ee930168a727e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505780
Commit-Queue: Alexis Menard \<[e-mail]>
Reviewed-by: Jonathan Lee \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1454533}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=32412716c0a08cef9ed666dd1b659ee505001cbb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

FAIL : 2
ERROR: 2

Chrome

OK : 2
PASS : 1
FAIL : 1

Safari

FAIL : 2
ERROR: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /viewport-segments/viewport-segments-env-variables.https.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • Tests the Viewport Segments Media Query change event handler.: FAIL (Chrome: PASS, Safari: FAIL)
• /viewport-segments/viewport-segments-segments-property.https.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • Tests the Viewport Segments Media Query change event handler.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1964053 [wpt PR 52285] - [Viewport Segments] Fix WPT tests not working on wpt.fyi, a=testonly

Automatic update from web-platform-tests
[Viewport Segments] Fix WPT tests not working on wpt.fyi

It turns out that the runner may have a viewport with dimensions which
will not return an integer if divided by 2 (to put the display feature
in the middle). set_display_features expect an integer so let's make sure we give it one. Also make sure we allow for rounding errors when checking the values of the segments.

Bug: 40137084
Change-Id: I713be16200f78cdca15e80d0397ee930168a727e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505780
Commit-Queue: Alexis Menard <[e-mail]>
Reviewed-by: Jonathan Lee <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1454533}

--

wpt-commits: 556ae05b4337fbd45c6ec77edecdad1582a020e2
wpt-pr: 52285

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93e100533243
[wpt PR 52285] - [Viewport Segments] Fix WPT tests not working on wpt.fyi,

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/93e100533243