1964092 - Add JSLargeAllocationFailure and JSOutOfMemory to the crash ping

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Apparently this will need (thanks Alex)

1. Data review (though strictly speaking this is technical data that we'd 100% gather via other means)
2. Somehow plumbing from RecordAnnotationCString to the ping.

I have the "change the YAML" file written... unless that's actually not necessary because https://searchfox.org/mozilla-central/source/toolkit/crashreporter/nsExceptionHandler.cpp#1332-1366 does all the work.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1964092 - Change scope for JSLargeAllocationFailure and JSOutOfMemory crash annotation to put it in pings r?afranchuk

Comment 2

[Alex Franchuk [:afranchuk]]

FWIW the data review can be self-administered with the data-classification-low tag on Phabricator (by your reviewers). I agree that it's technical data and should be fine in the ping.

The plumbing involved is to add associated glean metrics and populate them with the annotation value. This is fairly straightforward (though we really would like it to be simpler with bug 1950749), and I have docs linking to the pertinent locations in bug 1959435, they just haven't landed yet.

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

To be clear is the plumbing necessary on the server data-ingest side or report generation? it's not entirely clear reading those bugs. (Admittedly part of the problem being I can't tell how annotations are treated the same or differently for pings in the crash reporter code)

Comment 4

[Alex Franchuk [:afranchuk]]

It's all on the client/generation side. The annotations are stripped down to those with the appropriate scope when creating a ping. You don't need to worry about that particular distinction, you just need to ensure it gets set in the Glean ping metrics.

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1964092 - Add JSLargeAllocationFailure and JSOutOfMemory to desktop crash pings r?afranchuk

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1964092 - Add JSLargeAllocationFailure and JSOutOfMemory to fenix crash pings r?afranchuk

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c64990dcea1
Change scope for JSLargeAllocationFailure and JSOutOfMemory crash annotation to put it in pings r=afranchuk
https://hg.mozilla.org/integration/autoland/rev/e259116728ce
Add JSLargeAllocationFailure and JSOutOfMemory to desktop crash pings r=afranchuk
https://hg.mozilla.org/integration/autoland/rev/1bc29dd1883a
Add JSLargeAllocationFailure and JSOutOfMemory to fenix crash pings r=afranchuk,android-reviewers,nalexander

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5c64990dcea1
https://hg.mozilla.org/mozilla-central/rev/e259116728ce
https://hg.mozilla.org/mozilla-central/rev/1bc29dd1883a