1964136 - [wpt-sync] Sync PR 52293 - [Grid] Only create implicit lines when a dimension is subgridded

Status: NEW

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52293 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52293
Details from upstream follow.

Kurt Catti-Schmidt (SCHMIDT) <[e-mail]> wrote:

[Grid] Only create implicit lines when a dimension is subgridded

This change fixes an existing bug in our grid-area inheritance
for subgrids that I recently discovered. We are properly filtering
the line names, but we shouldn't be creating implicit lines at
all for dimensions that aren't subgridded.

Bug: 413563557
Change-Id: Ibd0145dd2a4199e6f12eff4c8447a8dc5b9ec906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6506362
Commit-Queue: Kurt Catti-Schmidt \<[e-mail]>
Reviewed-by: Ethan Jimenez \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1454740}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d24ed07bc423cab156a11a08ac4e42d8df890574

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base