1964159 - [wpt-sync] Sync PR 52305 - [scroll-marker] Adhere more closely to active marker selection algo

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52305 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52305
Details from upstream follow.

David Awogbemila <[e-mail]> wrote:

[scroll-marker] Adhere more closely to active marker selection algo

In the linked bug, we select a scroll marker while its target element
is not even within the scrollport.

This patch addresses this by adhering more closely to the spec'd
algorithm[1] which addresses this situation by stipulating that a
scroll target whose scroll position has not yet been reached should
only be selected if it is within half a scroll port of the current
scroll position.

We have clarified that although the algorithm[1] is not presented as
normative at the moment, the intention is to make it normative at some
point in the future.

[1] https://drafts.csswg.org/css-overflow-5/#example-d2ca6884

Bug: 413645441
Change-Id: I620cfa8a06cbd4f8f904fdaaef250351110b56dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505661
Commit-Queue: David Awogbemila \<[e-mail]>
Reviewed-by: Steve Kobes \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1455009}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9263cec67b13bdf34da7f7225c51077609b9f037

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-overflow/scroll-marker-active-unreached-target.html [wpt.fyi]
  • target whose target position is not yet reached only get selected when its less than half a scroll port away.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1964159 [wpt PR 52305] - [scroll-marker] Adhere more closely to active marker selection algo, a=testonly

Automatic update from web-platform-tests
[scroll-marker] Adhere more closely to active marker selection algo

In the linked bug, we select a scroll marker while its target element
is not even within the scrollport.

This patch addresses this by adhering more closely to the spec'd
algorithm[1] which addresses this situation by stipulating that a
scroll target whose scroll position has not yet been reached should
only be selected if it is within half a scroll port of the current
scroll position.

We have clarified that although the algorithm[1] is not presented as
normative at the moment, the intention is to make it normative at some
point in the future.

[1] https://drafts.csswg.org/css-overflow-5/#example-d2ca6884

Bug: 413645441
Change-Id: I620cfa8a06cbd4f8f904fdaaef250351110b56dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505661
Commit-Queue: David Awogbemila <[e-mail]>
Reviewed-by: Steve Kobes <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1455009}

--

wpt-commits: 4f6b0d09bdbd06eeff92a6b8007237791a0b13de
wpt-pr: 52305

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1964159 [wpt PR 52305] - Update wpt metadata, a=testonly

wpt-pr: 52305
wpt-type: metadata

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5509a2c48da5
[wpt PR 52305] - [scroll-marker] Adhere more closely to active marker selection algo,
https://hg.mozilla.org/integration/autoland/rev/adbbe6713825
[wpt PR 52305] - Update wpt metadata,

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5509a2c48da5
https://hg.mozilla.org/mozilla-central/rev/adbbe6713825