1964162 - [wpt-sync] Sync PR 52306 - Don't allow fixedpos CBs to be inline when fragmenting

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52306 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52306
Details from upstream follow.

Alison Maher <[e-mail]> wrote:

Don't allow fixedpos CBs to be inline when fragmenting

CL:3573056 added support for fixedpos elements nested in an abspos,
nested in an inline container when fragmenting. In summary, the change
intended to avoid setting the fixedpos containing block that we pass up
within a fragmentation context to an inline element.

The logic for handling this missed a case where the fixedpos inline
container was already set, but we run into another ancestor that is a
candidate for a fixedpos CB, but is inline.

Previously, we allowed this element to be set as the fixedpos CB. This
CL adjusts the logic to avoid this, which fixes a crash we were hitting
in this case.

Bug: 406053621
Change-Id: I709d7f36643898ed5bc910a1685e3bcaeb9e1617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6506648
Auto-Submit: Alison Maher \<[e-mail]>
Commit-Queue: Morten Stenshorne \<[e-mail]>
Reviewed-by: Morten Stenshorne \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1455050}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=369213fcd9f2840d4eb24d0ee2b1a0c3c98c0caa

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1964162 [wpt PR 52306] - Don't allow fixedpos CBs to be inline when fragmenting, a=testonly

Automatic update from web-platform-tests
Don't allow fixedpos CBs to be inline when fragmenting

CL:3573056 added support for fixedpos elements nested in an abspos,
nested in an inline container when fragmenting. In summary, the change
intended to avoid setting the fixedpos containing block that we pass up
within a fragmentation context to an inline element.

The logic for handling this missed a case where the fixedpos inline
container was already set, but we run into another ancestor that is a
candidate for a fixedpos CB, but is inline.

Previously, we allowed this element to be set as the fixedpos CB. This
CL adjusts the logic to avoid this, which fixes a crash we were hitting
in this case.

Bug: 406053621
Change-Id: I709d7f36643898ed5bc910a1685e3bcaeb9e1617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6506648
Auto-Submit: Alison Maher <[e-mail]>
Commit-Queue: Morten Stenshorne <[e-mail]>
Reviewed-by: Morten Stenshorne <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1455050}

--

wpt-commits: 5dad7f0970ccfd5a0f6760a74c91331e8fc8cc89
wpt-pr: 52306

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/244270eb05fa
[wpt PR 52306] - Don't allow fixedpos CBs to be inline when fragmenting,

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/244270eb05fa