1964198 - [wpt-sync] Sync PR 52313 - Fix a test to declare line-height with Ahem.

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52313 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52313
Details from upstream follow.

Daniel Holbert <[e-mail]> wrote:

Fix a test to declare line-height with Ahem.

This fixes the test align-self-static-position-005.html and its reference from recent PR https://github.com/web-platform-tests/wpt/pull/52260 to declare a line-height of 1 when specifying the Ahem font, per best practices at https://web-platform-tests.org/writing-tests/ahem.html

Per that documentation: when using Ahem in a WPT, "An explicit (i.e., not normal) line-height should also always be used")

This is needed in order for the test to pass in Firefox, since Gecko uses a larger-than-1 value as the "normal" line-height for Ahem.)

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 52313 applied with additional changes from upstream: 638746ee666a0825f63b6afbd18eca8b82bd9dc9

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=855ebbebe2278ba187e3d8309ec67aab5321ce8a

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1964198 [wpt PR 52313] - Fix a test to declare line-height with Ahem., a=testonly

Automatic update from web-platform-tests
Fix a test to declare line-height with Ahem. (#52313)

This fixes the test align-self-static-position-005.html and its reference
from recent PR https://github.com/web-platform-tests/wpt/pull/52260 to declare
a line-height of 1 when specifying the Ahem font, per best practices at
https://web-platform-tests.org/writing-tests/ahem.html

Per that documentation: when using Ahem in a WPT, "An explicit (i.e., not
normal) line-height should also always be used")

This is needed in order for the test to pass in Firefox, since Gecko uses a
larger-than-1 value as the "normal" line-height for Ahem.)

wpt-commits: dd8bc79937cc33e720381c68b37af6254e301e8a
wpt-pr: 52313

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/723741c630a6
[wpt PR 52313] - Fix a test to declare line-height with Ahem.,

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/723741c630a6