Closed Bug 1964199 Opened 15 days ago Closed 5 days ago

[wpt-sync] Sync PR 52314 - Allow <input> in <select> with wrapper tags

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
140 Branch
Tracking Status
firefox140 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(2 files)

Sync web-platform-tests PR 52314 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52314
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Allow <input> in <select> with wrapper tags

This patch makes \<input> get parsed as expected in \<select> if there is
another tag in between the \<select> and \<input>, such as
\<select>\<div>\<input>, in order to ensure compatibility with the legacy
behavior where \<input> adds a closing \</select> tag.

Bug: 402429384
Change-Id: Iff21245d0555844aa636eb002866bb3ed5af4d42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435161
Reviewed-by: Mason Freed \<masonf@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1455251}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 16 subtests

Status Summary

Firefox

OK : 1
PASS: 8
FAIL: 8

Chrome

OK : 1
PASS: 15
FAIL: 1

Safari

OK : 1
PASS: 8
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/forms/the-select-element/customizable-select/select-parsing.tentative.html [wpt.fyi]
    • <div>s, <button>s, and <datalist>s should be allowed in <select>: FAIL (Chrome: PASS, Safari: FAIL)
    • </select> should close <button>: FAIL (Chrome: PASS, Safari: FAIL)
    • </select> should close <datalist>: FAIL (Chrome: PASS, Safari: FAIL)
    • <select> in <button> in <select> should remove inner <select>: FAIL (Chrome: PASS, Safari: FAIL)
    • <select> in <select><button><div> should remove inner <select>: FAIL (Chrome: PASS, Safari: FAIL)
    • Divs and imgs should be allowed as direct children of select and within options without a datalist: FAIL (Chrome: PASS, Safari: FAIL)
    • textarea tags should parse inside select instead of closing the select: FAIL (Chrome: PASS, Safari: FAIL)
    • Input tags should parse inside select if nested in another tag: FAIL (Chrome: FAIL, Safari: FAIL)
Component: CSS Parsing and Computation → DOM: Core & HTML

Automatic update from web-platform-tests
Allow <input> in <select> with wrapper tags

This patch makes <input> get parsed as expected in <select> if there is
another tag in between the <select> and <input>, such as
<select><div><input>, in order to ensure compatibility with the legacy
behavior where <input> adds a closing </select> tag.

Bug: 402429384
Change-Id: Iff21245d0555844aa636eb002866bb3ed5af4d42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435161
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1455251}

--

wpt-commits: 598e8867a9abe53512f2baffad1192d554c69ced
wpt-pr: 52314

Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfd9e29e65c7 [wpt PR 52314] - Allow <input> in <select> with wrapper tags, https://hg.mozilla.org/integration/autoland/rev/bfb996143430 [wpt PR 52314] - Update wpt metadata,
Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: