1964219 - Jittery canvas rendering when gfx.direct2d.disabled = false

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[6k64x4ma]

Attachment: about_support.json

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:139.0) Gecko/20100101 Firefox/139.0

Steps to reproduce:

1. Set "gfx.direct2d.disabled" to false and restart Firefox.
2. Go to https://keyou.github.io/CanvasMark/ and run the benchmark.
3. Observe the first test.

Actual results:

The movement of the asteroids becomes unstable compared to when running on Firefox 138.

Expected results:

The asteroids moves smoothly.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d1cfe436879aa5f39e94e0781d10f2f792d30d9a&tochange=67917707ff5e57cd60e3f51c2799757a3a469c68

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sotaro, since you are the author of the regressor, bug 1959856, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Erich Gubler [:ErichDonGubler]]

Will also NI Lee, since he reviewed the regressor and is also an SME for Direct2D.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1964219 - Fix DXGITextureHostD3D11 Fence handling

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbd1386088f0
Fix DXGITextureHostD3D11 Fence handling r=lsalzman

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cbd1386088f0

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1959856

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sotaro, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Sotaro Ikeda [:sotaro]]

Hi 6k64x4ma, can you check if the problem is addressed with latest Nightly?

Comment 9

[6k64x4ma]

The issue did not occur with build ID 20250508215032, thanks.

Comment 10

[Sotaro Ikeda [:sotaro]]

Great! Thank you.

Comment 11

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9486203 [details]
Bug 1964219 - Fix DXGITextureHostD3D11 Fence handling

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Canvas rendering causes jittering when pref gfx.direct2d.disabled = false on Windows.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is not used with default pref. And with the change, the fence handling becomes same to SharedSurface_ANGLEShareHandle::ProducerReleaseImpl() that is already used with WebGL.
• String changes made/needed: none
• Is Android affected?: No

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9486203 [details]
Bug 1964219 - Fix DXGITextureHostD3D11 Fence handling

Approved for 139.0b7

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8fb0a752226c