1964228 - Fix media query for accent color in titlebar + mica.

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1957231

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1964228 - Fix media query for windows mica + use accent color in titlebar. r=#theme

Mica with that windows setting needs to behave like that as the system
backdrop doesn't provide anything else.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61567ba22d5a
Fix media query for windows mica + use accent color in titlebar. r=desktop-theme-reviewers,dao

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/61567ba22d5a

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1964228 - Fix media query for windows mica + use accent color in titlebar. r=#theme

Mica with that windows setting needs to behave like that as the system
backdrop doesn't provide anything else.

Original Revision: https://phabricator.services.mozilla.com/D247695

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: in some non-default configurations there's low contrast on the tab bar
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Set windows appearance settings to: Light mode, Use accent color in titlebar and window borders. Enable widget.windows.mica
• Risk associated with taking this patch: low
• Explanation of risk level: non-default configuration, one line css fix
• String changes made/needed: none
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a7935dac448c

Comment 9

[Daniel Bodea [:danibodea]]

Emilio, can you explain what the issue is here? There is no actual/expected results that I can use to verify the fix. Thanks!

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: screenshot

Sure, see the color of e.g. the new tab button on this screenshot (pre patch), when having the configuration described in comment 7 (Light mode, Use accent color in titlebar and window borders, widget.windows.mica=true).

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Screenshot post-patch

This is with the patch applied.

Comment 12

[Daniel Bodea [:danibodea]]

This appears to be an issue specific to Windows 11. This "widget.windows.mica" pref does not have any changes on Windows 10.

I can reproduce this issue in Nightly v140.0a1 from 2025-05-02 and Beta 139.0b1 and I can confirm the fix in Nightly v140.0a1 from 2025-05-12 and Beta v139.0b7. The buttons from the Top bar are displayed in light color and not dark grey (under the circumstances mentioned). Furthermore, the color properly changes when the pref is flipped.