1964328 - NetworkGeolocationProvider should check the status before calling json()

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, enhancement)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

https://searchfox.org/mozilla-central/rev/4c065f1df299065c305fb48b36cdae571a43d97c/dom/system/NetworkGeolocationProvider.sys.mjs#496-498

    let req = await fetch(url, fetchOpts);
    lazy.clearTimeout(timeoutId);
    let result = req.json();

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1964328 - Check response status before calling json() r=#dom-core

This should help investigate what's happening in bug 1823283.

Also use AbortSignal.timeout instead of manual set/clearTimeout.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/566abd3030f3
Check response status before calling json() r=dom-core,sefeng

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/693747559896
Revert "Bug 1964328 - Check response status before calling json() r=dom-core,sefeng" for causing location related failures.

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing location related failures.

Push with failures

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=506731552&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=506731508&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=506733058&repo=autoland

Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af9dba0a1b1e
Check response status before calling json() r=dom-core,sefeng

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/af9dba0a1b1e