1964399 - [wpt-sync] Sync PR 52338 - ScopedVT: Add checks for scope elements that are not rendered.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52338 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52338
Details from upstream follow.

Steve Kobes <[e-mail]> wrote:

ScopedVT: Add checks for scope elements that are not rendered.

(1) If the scope element has no ComputedStyle, do not create a pseudo
element tree. This can happen if the scope element is inside the light
DOM of a shadow host, but does not appear in the flat tree.

(2) If the scope element has no LayoutObject, don't look for tagged
participants inside it. This happens if scope has display:none style.
Tag discovery uses paint order, so it requires a PaintLayer.

Bug: 412265459
Change-Id: I848cd438b043dbdba35a66177ba7ed6256e6cc44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505605
Reviewed-by: Kevin Ellis \<[e-mail]>
Commit-Queue: Steve Kobes \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1455654}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e985e356828d42b810e5e58da93d310540cceef

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

TIMEOUT: 1

Chrome

PASS : 1

Safari

TIMEOUT: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-view-transitions/scoped/crashtests/shadow-dom.html [wpt.fyi]: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1964399 [wpt PR 52338] - ScopedVT: Add checks for scope elements that are not rendered., a=testonly

Automatic update from web-platform-tests
ScopedVT: Add checks for scope elements that are not rendered.

(1) If the scope element has no ComputedStyle, do not create a pseudo
element tree. This can happen if the scope element is inside the light
DOM of a shadow host, but does not appear in the flat tree.

(2) If the scope element has no LayoutObject, don't look for tagged
participants inside it. This happens if scope has display:none style.
Tag discovery uses paint order, so it requires a PaintLayer.

Bug: 412265459
Change-Id: I848cd438b043dbdba35a66177ba7ed6256e6cc44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6505605
Reviewed-by: Kevin Ellis <[e-mail]>
Commit-Queue: Steve Kobes <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1455654}

--

wpt-commits: c11e6a428b9f95b1d514cda540e5c190aba4606f
wpt-pr: 52338

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1964399 [wpt PR 52338] - Update wpt metadata, a=testonly

wpt-pr: 52338
wpt-type: metadata

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/531825a5c288
[wpt PR 52338] - ScopedVT: Add checks for scope elements that are not rendered.,
https://hg.mozilla.org/integration/autoland/rev/07b5cefdee3f
[wpt PR 52338] - Update wpt metadata,

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/531825a5c288
https://hg.mozilla.org/mozilla-central/rev/07b5cefdee3f