1964432 - [wpt-sync] Sync PR 52339 - cc/vt: Another speculative fix for view-transition-types-mutable-no-document-element-crashtest.html

Status: NEW

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52339 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52339
Details from upstream follow.

Vladimir Levin <[e-mail]> wrote:

cc/vt: Another speculative fix for view-transition-types-mutable-no-document-element-crashtest.html

This patch does the following:

• Wait for the compositor to be ready before running a VT test.

This passes with 500 runs (100 iterations / 5 each).

R=[e-mail]

Bug: 413305967
Change-Id: Ibe37db724777d885e812f1fd2c6f3d41a1c861b5
Reviewed-on: https://chromium-review.googlesource.com/6506166
WPT-Export-Revision: 34b9a8a2ca6414a0abf3d8a1a050b76a1b654222

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 52339 applied with additional changes from upstream: ecf7b727cab2108b27488146a78a5c6c60b66e3d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=71a219a8a40670d9f31e6db9e572ee04667001e9

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-view-transitions/view-transition-types-mutable-no-document-element-crashtest.html [wpt.fyi]
  • ViewTransitionTypeSet should not crash when documentElement is null: FAIL linked bug:Bug 1964188

New Tests That Don't Pass

• /css/css-view-transitions/view-transition-types-mutable-no-document-element-crashtest.html [wpt.fyi]
  • ViewTransitionTypeSet should not crash when documentElement is null: FAIL (Chrome: PASS, Safari: PASS)

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1964432 [wpt PR 52339] - cc/vt: Another speculative fix for view-transition-types-mutable-no-document-element-crashtest.html, a=testonly

Automatic update from web-platform-tests
cc/vt: Another speculative fix for view-transition-types-mutable-no-document-element-crashtest.html

This patch does the following:

• Wait for the compositor to be ready before running a VT test.

This passes with 500 runs (100 iterations / 5 each).

R=[e-mail]

Bug: 413305967
Change-Id: Ibe37db724777d885e812f1fd2c6f3d41a1c861b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6506166
Commit-Queue: Vladimir Levin <[e-mail]>
Reviewed-by: Kevin Ellis <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1455716}

--

wpt-commits: d8b209ae839eadb200ffd2ccd60bdcd23c652ccc
wpt-pr: 52339

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a60042e3bae
[wpt PR 52339] - cc/vt: Another speculative fix for view-transition-types-mutable-no-document-element-crashtest.html,