1964939 - Clobbering in jj repo on Windows complains about find command (with empty objdir)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[:Gijs (he/him)]

https://searchfox.org/mozilla-central/rev/4c065f1df299065c305fb48b36cdae571a43d97c/python/mozbuild/mozbuild/mach_commands.py#569-582

    cmd = ["find", ".", "-type", "f", "-name", "*.py[cdo]", "-delete"]
    subprocess.call(cmd, cwd=command_context.topsrcdir)
    cmd = [
        "find",
        ".",
        "-type",
        "d",
        "-name",
        "__pycache__",
        "-empty",
        "-delete",
    ]
ret = subprocess.call(cmd, cwd=command_context.topsrcdir)

outputs:

File not found - *.py[cdo]
FIND: Parameter format not correct

When run from a mozilla-build shell. The all caps "FIND" makes me suspect the subprocess call is running inside cmd and using the Windows "find" executable instead of the *nix one.

Comment 1

[:Gijs (he/him)]

(it's a colocated jj/git repo so it's also possible that this is an issue with the git command right above it.)

Comment 2

[:Gijs (he/him)]

Mossop says this only shows up if the objdir is already empty.

Comment 3

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1964939 - Use `git` to clobber with `jj` and make the 'no-vcs' fallback pure python r?#build

For now, we assume all jj repos are git colocated, so we can do this
portion of the clobber the same way for jj as we do for git.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c71f8e790f4
Use `git` to clobber with `jj` and make the 'no-vcs' fallback pure python r=firefox-build-system-reviewers,glandium

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/4c71f8e790f4