Closed Bug 196499 Opened 22 years ago Closed 21 years ago

duplicate entries in final-link-comps

Categories

(SeaMonkey :: Build Config, defect, P4)

x86
Windows 2000
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.5alpha

People

(Reporter: deanis74, Assigned: netscape)

Details

Attachments

(1 file)

I'm building the phoenix.exe, but I think this is a general build problem. 
After I build the entire tree once, if I do a make in one specific component
directory, that entry gets added to final-link-comp and final-link-comp-names. 
This causes errors when doing subsequent makes in browser/app, when building
nsStaticComponents.cpp.

1. Build phoenix.exe from scratch.
2. Do a "make" in widget/src/build.
3. Do a "make" in browser/app.

Expected results: everything's a-ok.

Actual results: Error about something methods being already defined when
compiling nsStaticComponents.cpp.  To resolve this I have to edit
final-link-comps and remove the duplicate 'nsWidgetModule' line at the bottom. 
It looks like we're not checking for duplicates before adding modules to this
file.  Same goes for final-link-comp-names.
Sounds like a line-ending issue.  build-list.pl already checks for duplicates. 
Which line-endings do you have cygwin configured to use and which variant of
perl are you using?
"This is perl, v5.6.1 built for cygwin-multi"

How do I check line-endings?
Check your mount points.  If they say binmode, then they are using unix
line-endings.  If it says textmode, then it's using dos line-endings.  cygwin
perl should auto-translate regardless though.  I may have to force that script
to use binmode.

All mounts are textmode.
Can you attach one of the files (gzipped) which contains duplicate entries?
Oh man, I'll have to build static again.
Priority: -- → P4
Target Milestone: --- → mozilla1.5alpha
Attached patch v1.0Splinter Review
Force the list file to be read & written using binary mode so no line-ending
translations are done.
I don't have to do anything else besides apply this patch, do I?  I applied the
patch and did a build in xpfe\components\build, and "appcomps" is duplicated in
final-link-comps and "application" is final-link-comp-names.
Just applying the patch should have worked.  Can you attach those final-link-*
files which have the duplicate entries?
Hrm.  I thought it didn't work, but now I can't get this behavior anymore.  I
think this patch does the trick.
Patch has been checked in.  Reopen if you can duplicate the problem again.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: