Open Bug 1965019 Opened 13 days ago Updated 13 days ago

Wrongly redacted path names in lando error

Categories

(Conduit :: Lando, defect)

Product:
Conduit
Component:
Lando
Type:
defect

Tracking

(Not tracked)

People

(Reporter: emilio, Unassigned)

Details

See errors in https://lando.moz.tools/D248089/

Checking patch third_party/webkit/PerformanceTests/StyleBench/resources/[REDACTED]@2x.png...
error: the patch applies to 'third_party/webkit/PerformanceTests/StyleBench/resources/[REDACTED]@2x.png' (e69de29bb2d1d6434b8b29ae775ad8c2e48c5391), which does not match the current contents.

The file's guage@2x.png, which is matching the URL_USERINFO_RE at https://github.com/mozilla-conduit/lando/blob/7f4ca4c2234655612cac870c7ebe1aa6d01746bf/src/lando/main/scm/git.py#L483

We could fix this by requiring a : in the <userinfo> part of the regex - that would mean urls with usernames and passwords are redacted, those with just usernames are not, and we wouldn't hit on a filename that contains @.

You need to log in before you can comment on or make changes to this bug.