1965061 - Pretenure CallObject allocations

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Description

[Jon Coppeard (:jonco)]

Following on from bug 1898270 we can also pretenure call objects and named lambda objects created as part of the environment.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1965061 - Part 1: Add an allocation site for environment objects r?jandem

A pointer is added to ICScript to store the alloc site to use. A special PC
offset is used to distinguish this site from those associated with script
bytecode.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1965061 - Part 2: Record the heap to use for environment objects in the MIR r?jandem

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1965061 - Part 3: Use alloc site information to pretenure environment objects r?jandem

Comment 4

[Jon Coppeard (:jonco)]

With this change the tenuring rate for the testcase in bug 1958441 drops from 50% to 30%.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/709f58f3b5fd
Part 1: Add an allocation site for environment objects r=jandem
https://hg.mozilla.org/integration/autoland/rev/bce1bcc2a3b1
Part 2: Record the heap to use for environment objects in the MIR r=jandem
https://hg.mozilla.org/integration/autoland/rev/60c7e85861e2
Part 3: Use alloc site information to pretenure environment objects r=jandem

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/709f58f3b5fd
https://hg.mozilla.org/mozilla-central/rev/bce1bcc2a3b1
https://hg.mozilla.org/mozilla-central/rev/60c7e85861e2