Open Bug 1965105 Opened 5 days ago Updated 5 days ago

[wpt-sync] Sync PR 52394 - Improve interaction-with-paint-before-back.tentative.html.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 52394 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52394
Details from upstream follow.

Johannes Henkel <johannes@chromium.org> wrote:

Improve interaction-with-paint-before-back.tentative.html.

  • Move the logic inside promise_test.
  • No longer use soft-navigation-helper.js, to make this easier
    to understand.
  • Avoid using images as click targets (or rather, a tags
    that have no children except for images); I think text
    is actually more reliable here, since it doesn't
    need to be fetched from the network. So, I'm hoping this
    will fix the flakiness without having to insert trickery
    into the test that ensures the images that the driver clicks
    on have been displayed (decode vs. observing paints etc.).
  • Add some comments and simplify the logic. I tried to
    simplify / remove everything that I don't understand, while
    keeping the spirit of the test.

Bug: 324536287
Change-Id: I19db87d9d9a4d0d23822ab8946030c7318ef6a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6512252
Commit-Queue: Johannes Henkel \<johannes@chromium.org>
Reviewed-by: Michal Mocny \<mmocny@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1457248}

PR 52394 applied with additional changes from upstream: 25457aed7ddd7e1723fa81bf2a285d8d5fdfe6eb

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

TIMEOUT: 2

Chrome

OK : 1
PASS : 1

Safari

TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /soft-navigation-heuristics/interaction-with-paint-before-back.tentative.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
    • Ensure that soft navigation entry emitted through a synchronous event that modified DOM and committed a same document navigation, and that was preceded by a user interaction that resulted in a contentful paint is properly detected.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

Tests Disabled in Gecko Infrastructure

  • /soft-navigation-heuristics/interaction-with-paint-before-back.tentative.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
You need to log in before you can comment on or make changes to this bug.