1965305 - Broken Commit Link After Failed Patch Landing in Lando

Status: RESOLVED DUPLICATE of bug 1963846

(Conduit :: Lando, defect, P3)

Description

[Alastor Wu [:alwu]]

When a patch fails to land, clicking the commit link (the one after the @ ) results in a 404 error. It should direct me to a valid file or commit view so I can see the current version of the file.

Eg.
Check this lando page https://lando.moz.tools/D247368/

Comment 1

[Connor Sheehan [:sheehan]]

Looks like the repo URL is https://github.com/mozilla-firefox/firefox.git/tree/bf3516e81e1f61953ddd73956fb2c28fd81c35ee/dom/ipc/ContentParent.h with a .git suffix on the Github URL, when it should be https://github.com/mozilla-firefox/firefox/tree/bf3516e81e1f61953ddd73956fb2c28fd81c35ee/dom/ipc/ContentParent.h without the .git suffix.

Comment 2

[Zeid [:zeid]]

We should add a Repo.normalized_github_base_url property to take care of this case, and the existing fixups that were made in a similar fashion.