1966073 - Enable Close Watcher by default

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Sebastian Zartner [:sebo]]

Once enabled, this needs to be documented at https://developer.mozilla.org/en-US/docs/Web/API/CloseWatcher and the related browser compat data plus the release notes on MDN.

And Keith, maybe you can also request this to be added to the Firefox release notes.

Sebastian

Comment 2

[Keith Cirkel [:keithamus]]

Attachment: Bug 1966073 - Enable CloseWatcher by default r?#dom-core

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f43edf0ad26b
https://hg.mozilla.org/integration/autoland/rev/11ab84c45902
Enable CloseWatcher by default r=dom-core,smaug

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/11ab84c45902

Comment 6

[Keith Cirkel [:keithamus]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Support for the CloseWatcher interface, and its integration with dialogs & popovers
[Affects Firefox for Android]: Yes (also with some android specific behavior)
[Suggested wording]: Add support for closing popovers & dialogs with the Android 'Back Button', and implement the CloseWatcher API for handling this in script.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/CloseWatcher

(Please improve my wording, it's not great).

Comment 7

[Pascal Chevrel:pascalc]

(In reply to Keith Cirkel [:keithamus] from comment #6)

Release Note Request (optional, but appreciated)
[Why is this notable]: Support for the CloseWatcher interface, and its integration with dialogs & popovers
[Affects Firefox for Android]: Yes (also with some android specific behavior)
[Suggested wording]: Add support for closing popovers & dialogs with the Android 'Back Button', and implement the CloseWatcher API for handling this in script.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/CloseWatcher

(Please improve my wording, it's not great).

Is that an Android-only improvement?

Comment 8

[Keith Cirkel [:keithamus]]

CloseWatcher is exposed to all platforms, and mitigates abusive strategies for multiple dialogs/popovers (effectively, pressing Escape twice will force these to close). Developers can use the CloseWatcher interface to also tie into this behaviour.

The Android specific behaviour is that the back button now consumes a CloseWatcher (the equivalent of the Escape key). This means the back button will now close Dialogs/Popovers on first click.

So it's an improvement on all platforms, with specific features for Android.

Comment 9

[Pascal Chevrel:pascalc]

Note added to 149 nightly release notes with this wording:

Added support for closing popovers & dialogs with the Android Back Button, and implement the CloseWatcher API for handling this in script.

I am keeping the relnote-firefox? flag set until we include this note in our final 149 release notes, thanks.

Comment 10

[Hamish Willee]

FF149 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/43220 .
Comatibility data already updated and docs look OK, so mostly just release note.