Closed
Bug 196644
Opened 23 years ago
Closed 23 years ago
get rid of class nsMenuListenerAccessible
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: yuanyi21, Assigned: yuanyi21)
Details
Attachments
(1 file)
|
3.69 KB,
patch
|
aaronlev
:
review+
Henry.Jia
:
superreview+
|
Details | Diff | Splinter Review |
seems nobody needs this class any more, there are just the declaration and
implemetation in nsBaseWidgetAccessible.cpp/.h, but no code reference, even in
comments.
and since bug 193987 fixed, I always get warning when compiling mozilla on
Linux like this:
../base/nsAccessible.h:113: warning: `virtual nsresult
nsAccessible::HandleEvent(unsigned int, nsIAccessible*, void*)' was hidden
../base/nsBaseWidgetAccessible.h:141: warning: by `virtual nsresult
nsMenuListenerAccessible::HandleEvent(nsIDOMEvent*)'
aaron, jgaunt, any objection?
|
||
Comment 1•23 years ago
|
||
fixed
|
|
||
Comment 2•23 years ago
|
||
sorry, I mean "Yes, let's get rid of it."
Attachment #116917 -
Flags: superreview?(Henry.Jia)
Attachment #116917 -
Flags: review?(aaronl)
|
|
||
Comment 4•23 years ago
|
||
Comment on attachment 116917 [details] [diff] [review]
get rid of class nsMenuListenerAccessible
r=aaronl
Attachment #116917 -
Flags: review?(aaronl) → review+
Comment on attachment 116917 [details] [diff] [review]
get rid of class nsMenuListenerAccessible
sr=Henry
Attachment #116917 -
Flags: superreview?(Henry.Jia) → superreview+
fixed!
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•