1967026 - VoiceOver does not expose aria-brailleroledescription

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Morgan Reschenberg [:morgan]]

STR:

1. Enable VoiceOver
2. Ensure the braille viewer is turned on (VoiceOver Utility.app > Visuals > Panels & menus > Braille: "on")
3. Load data:text/html,<article aria-roledescription="slide"aria-brailleroledescription="sld"aria-labelledby="slide1heading"><h1 id="slide1heading">Welcome to my talk</h1><img alt="Me" src="images/me.jpg" /></article>
4. Focus the <article> with VoiceOver

Expected:
The braille panel should display "Welcome to my talk, sld"

Actual:
The braille panel displays "Welcome to my talk, slide"

This works in Safari. Per the spec we should expose this via AXBrailleRoleDescription

Comment 1

[Ben]

Hey, i'm a new contributor. I'm looking into this one ☺

Comment 2

[Morgan Reschenberg [:morgan]]

(In reply to Ben from comment #1)

Hey, i'm a new contributor. I'm looking into this one ☺

Hi Ben, thank you! I've assigned this bug to you.
Please use the requestion-information-from function (also called 'need info') to request help from me as needed (note, I won't be notified for new comments, only comments with 'need info's directed to me)

To start, I'd recommend looking at bug 1862999 and its associated patch to see how we traditionally add support for new attributes on macOS. Your patch should include similar function additions (you'll need a new mox- function for your attribute) as well as a test. The content of your added function will differ from the one in the patch, but may use existing utility functions like getAccAttr.

Comment 3

[Sally Frye]

Hi Morgan - I'm also a new contributor, working with Ben on this bug together. I am unclear on the meaning of "Focus on the article" in the directions to recreate the bug. My attempt to VoiceOver the text and image read the text the same way in both Firefox and Safari. Neither one mentioned the slide or sld as listed in the "Expected/Actual" outcomes.

Comment 4

[Morgan Reschenberg [:morgan]]

(In reply to Sally Frye from comment #3)

Hi Morgan - I'm also a new contributor, working with Ben on this bug together. I am unclear on the meaning of "Focus on the article" in the directions to recreate the bug. My attempt to VoiceOver the text and image read the text the same way in both Firefox and Safari. Neither one mentioned the slide or sld as listed in the "Expected/Actual" outcomes.

Hi Sally, nice to meet you :)
I'll add a screen recording for this so you have some more context for how to test. I've just verified this is still broken in Firefox and working in Safari. Let me know if you have questions, and thank you for your help !

Comment 5

[Morgan Reschenberg [:morgan]]

Attachment: bug 1967026 testing_720p.mov

Comment 6

[Sally Frye]

Attachment: WIP: Bug 1967026 - Adding aria-braille role description support for VoiceOver

Comment 7

[Morgan Reschenberg [:morgan]]

I see you've posted a WIP patch, I'll hold off on reviewing until you add myself (morgan) as a reviewer and hit "request review" in the phabricator UI.
Thanks for your work :)

Comment 8

[Sally Frye]

Attachment: Bug 1967026 - Add aria-braille role description support for VoiceOver r?morgan!

Comment 9

[Sally Frye]

We used Bug 1862999 as a template for making the adjustments to support Aria Braille Role Description, however we are not seeing any changes when manually re-creating the bug.

Apologies, there are technically 2 Phabricator pages now. The older version should now be abandoned, it's just a git file management error on my end. The proper one is the latter, D286383.

Would love for someone to take a look at what we've done so far and point us in a better direction. Trying to get a handle on where best to look for info.

Comment 10

[Sally Frye]

Found the error! It was a naming inconsistency in the MOXAccessibleProtocol.h file. It passes the local test we created as well as our manual recreation of the bug based on your video. It's ready for official review.

We ran the other mac/ folder tests and only had 1 error, resulting from a TIMEOUT in a test within browser_text_input.js. Not sure if it's related to the bug in any way.

Comment 11

[Morgan Reschenberg [:morgan]]

(In reply to Sally Frye from comment #10)

Found the error! It was a naming inconsistency in the MOXAccessibleProtocol.h file. It passes the local test we created as well as our manual recreation of the bug based on your video. It's ready for official review.

We ran the other mac/ folder tests and only had 1 error, resulting from a TIMEOUT in a test within browser_text_input.js. Not sure if it's related to the bug in any way.

Awesome, thanks for taking the time to look into the issue :)
Don't worry about that test failure, I'm reasonably certain it is unrelated to your work. Just in case, I've submitted a try run here which will run your test and the rest of our mac tests on our array of remote machines. If anything comes back flagged, I'll let you know.

In the meantime, I left a few comments on your patch. Please address them and re-push when you have some time. Thanks again!

Comment 12

[Sally Frye]

Attachment: Bug 1967026 - Add aria-brailleroledescription support for VoiceOver r?morgan!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e1ac13d9d495
https://hg.mozilla.org/integration/autoland/rev/f68e53118340
Add aria-braille role description support for VoiceOver r=morgan

Comment 14

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f68e53118340