196728 - textmail type editor can accept drops of data that are not valid

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Kathleen :Brade]

the textmail type editor can accept drops of data that are html, raw image data,
files, etc.

expectation: only textual drop should not be accepted

Comment 1

[Kathleen :Brade]

Attachment: add check of flags to see what flavors can be dropped

Comment 2

[Kathleen :Brade]

Comment on attachment 116779 [details] [diff] [review]
add check of flags to see what flavors can be dropped

seeking reviews

notes: 1) this block of code is inside "CanDrop"
 2) I don't think we should advertise jpegmime since we really don't handle it;
I don't know that it's possible to get such a flavor on the clipboard/drag
transferable.  Regardless, we don't support insertion of raw image data
insertion yet.	When we do support such insertion, I believe it'll be
nativeimage but that discussion belongs in a different bug.

Comment 3

[kinmoz]

Comment on attachment 116779 [details] [diff] [review]
add check of flags to see what flavors can be dropped

sr=[e-mail]

FYI for QA, brade and I discussed some scenarios that might be different as the
result of this change ... for example drag+drop of quoted reply text within the
same doc now converts the text to normal black text ... dropping links and
images from within the browser to composer should now drop urls instead of the
link and text that appears in the browser.

According to brade drop is now symetrical with	paste into plaintext editors
and other non-mozilla-plaintext apps.

Comment 4

[Dave Barrowman]

Discussed in EDT - plussing.

Comment 5

[Kathleen :Brade]

fix checked in

Comment 6

[sairuh (rarely reading bugmail)]

spun off bug 197266 for the case in comment 3, where dragged or copied text (in
plaintext mail compose) loses its blue-styled color.

other tests:

a. dragging a link from browser to plaintext mail compose pastes the URL (as
expected).

b. dragging an image from browser to plaintext mail compose only pastes the URL
of the image, not the image itself.

c. dragging a table from browser to plaintext mail compose only pastes the table
contents as tab-delimited text, not the table.

d'n'd btwn (a), (b) and (c) and an HTML mail compose window worked fine: items
were copied with html markup/style.

vrfy'ing fixed with 2003.03.13 comm trunk builds.