196795 - make HTMLDocumentColorRule immutable

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We should make the HTMLDocumentColorRule immutable.  (I was thinking this might
fix bug 90194, but then I realized the problem there is much deeper.)  However,
this patch is good since we want to move towards rule immutability.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 116826 [details] [diff] [review]
patch

>+  if (mDocumentColorRule) {
>+    mDocumentColorRule->mSheet = nsnull;
>+    NS_RELEASE(mDocumentColorRule);
>+  }

I guess we can't make this an nsCOMPtr because it doesn't have a no-argument
constructor, huh?  :(

r+sr=bzbarsky

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-03-13 07:30 PST.

Comment 4

[Madhur Bhatia]

well... i do suppose this bug can hve a [whitebox' in the status whiteboard,
since  the only way to verify this bug is by checking the code checkin.