Closed
Bug 196795
Opened 22 years ago
Closed 22 years ago
make HTMLDocumentColorRule immutable
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.4alpha
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Whiteboard: [patch][whitebox])
Attachments
(1 file)
6.22 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
We should make the HTMLDocumentColorRule immutable. (I was thinking this might
fix bug 90194, but then I realized the problem there is much deeper.) However,
this patch is good since we want to move towards rule immutability.
Assignee | ||
Comment 1•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [patch]
Target Milestone: --- → mozilla1.4alpha
Assignee | ||
Updated•22 years ago
|
Attachment #116826 -
Flags: superreview?(bzbarsky)
Attachment #116826 -
Flags: review?(bzbarsky)
![]() |
||
Comment 2•22 years ago
|
||
Comment on attachment 116826 [details] [diff] [review]
patch
>+ if (mDocumentColorRule) {
>+ mDocumentColorRule->mSheet = nsnull;
>+ NS_RELEASE(mDocumentColorRule);
>+ }
I guess we can't make this an nsCOMPtr because it doesn't have a no-argument
constructor, huh? :(
r+sr=bzbarsky
Attachment #116826 -
Flags: superreview?(bzbarsky)
Attachment #116826 -
Flags: superreview+
Attachment #116826 -
Flags: review?(bzbarsky)
Attachment #116826 -
Flags: review+
Assignee | ||
Comment 3•22 years ago
|
||
Fix checked in to trunk, 2003-03-13 07:30 PST.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 4•22 years ago
|
||
well... i do suppose this bug can hve a [whitebox' in the status whiteboard,
since the only way to verify this bug is by checking the code checkin.
Whiteboard: [patch] → [patch][whitebox]
You need to log in
before you can comment on or make changes to this bug.
Description
•