make HTMLDocumentColorRule immutable

RESOLVED FIXED in mozilla1.4alpha

Status

()

P3
normal
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla1.4alpha
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch][whitebox])

Attachments

(1 attachment)

We should make the HTMLDocumentColorRule immutable.  (I was thinking this might
fix bug 90194, but then I realized the problem there is much deeper.)  However,
this patch is good since we want to move towards rule immutability.
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [patch]
Target Milestone: --- → mozilla1.4alpha
Attachment #116826 - Flags: superreview?(bzbarsky)
Attachment #116826 - Flags: review?(bzbarsky)
Comment on attachment 116826 [details] [diff] [review]
patch

>+  if (mDocumentColorRule) {
>+    mDocumentColorRule->mSheet = nsnull;
>+    NS_RELEASE(mDocumentColorRule);
>+  }

I guess we can't make this an nsCOMPtr because it doesn't have a no-argument
constructor, huh?  :(

r+sr=bzbarsky
Attachment #116826 - Flags: superreview?(bzbarsky)
Attachment #116826 - Flags: superreview+
Attachment #116826 - Flags: review?(bzbarsky)
Attachment #116826 - Flags: review+
Fix checked in to trunk, 2003-03-13 07:30 PST.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 4

16 years ago
well... i do suppose this bug can hve a [whitebox' in the status whiteboard,
since  the only way to verify this bug is by checking the code checkin.
Whiteboard: [patch] → [patch][whitebox]
You need to log in before you can comment on or make changes to this bug.