1968644 - Add a flag in LoadInfo to indicate whether a request is from a tracker

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[Tim Huang[:timhuang]]

Introduce a flag in the LoadInfo to indicate whether a request is from a tracker. The flag should be set in the following scenarios

• A request from a tracking iframe
• A request from a tracking script

Comment 1

[Tim Huang[:timhuang]]

It will also cover subresource loads.

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1968644 - Part 1: Introduce triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags to LoadInfo. r?#necko!

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1968644 - Part 3: Populate the triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for fetch requests. r?edenchuang!

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug 1968644 - Part 4: Populate triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for loads. r?smaug!

Comment 5

[Tim Huang[:timhuang]]

Attachment: Bug 1968644 - Part 4: Populate triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for image loads. r?emilio!

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1968644 - Part 5: Populate triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for CSS loads. r?emilio!

Comment 7

[Tim Huang[:timhuang]]

Attachment: Bug 1968644 - Part 6: Populate triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags during channel creation. r?#necko!

Comment 8

[Tim Huang[:timhuang]]

Attachment: Bug 1968644 - Part 7: Add tests. r?#necko!,#anti-tracking!

Comment 9

[Tim Huang[:timhuang]]

Attachment: Bug 1968644 - Part 8: Populate the triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for WebSocket requests. r?valentin!

Comment 10

[Tim Huang[:timhuang]]

Attachment: Bug 1968644 - Part 2: Intorduce the ClassificationFlags to nsIClassifiedChannel.idl. r?dimi!

This newly introduced struct is to easily represent firstPartyClassificationFlags
and thirdPartyClassificationFlags. We will use this struct in IPC, so we
add the IPC traits implementation in this patch.

Comment 11

[Tim Huang[:timhuang]]

Attachment: Bug 1968644 - Part 9: Add more tests for loads triggered by tracking scripts. r?valentin!,#anti-tracking!

Comment 12

[Tim Huang[:timhuang]]

Attachment: Bug 1968644 - Part 10: Store JSCallingLocation and set the JSCallingLocation fallback for Media loads. r?emilio!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a7619a72b4c0
https://hg.mozilla.org/integration/autoland/rev/fdfd8b33bce4
Part 1: Introduce triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags to LoadInfo. r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/b8c01cd77c4e
https://hg.mozilla.org/integration/autoland/rev/aa35c59d796b
Part 2: Intorduce the ClassificationFlags to nsIClassifiedChannel.idl. r=dimi,necko-reviewers,valentin
https://github.com/mozilla-firefox/firefox/commit/08f090244fba
https://hg.mozilla.org/integration/autoland/rev/bb2fd3646504
Part 3: Populate the triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for fetch requests. r=valentin,smaug
https://github.com/mozilla-firefox/firefox/commit/7b3ba3b6689a
https://hg.mozilla.org/integration/autoland/rev/b0c45d183272
Part 4: Populate triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for loads. r=smaug,necko-reviewers
https://github.com/mozilla-firefox/firefox/commit/8a8fd7bacc02
https://hg.mozilla.org/integration/autoland/rev/2d50658e352f
Part 5: Populate triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for CSS loads. r=emilio
https://github.com/mozilla-firefox/firefox/commit/f564c21b371c
https://hg.mozilla.org/integration/autoland/rev/1787f44b7654
Part 6: Populate triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags during channel creation. r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/e52f034955e3
https://hg.mozilla.org/integration/autoland/rev/c3feee5dc849
Part 7: Add tests. r=necko-reviewers,anti-tracking-reviewers,emz,valentin
https://github.com/mozilla-firefox/firefox/commit/53a783a51e5e
https://hg.mozilla.org/integration/autoland/rev/ca204b3f1951
Part 8: Populate the triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for WebSocket requests. r=valentin,necko-reviewers
https://github.com/mozilla-firefox/firefox/commit/7d5c3e1c1ce9
https://hg.mozilla.org/integration/autoland/rev/f5998eb538ed
Part 9: Add more tests for loads triggered by tracking scripts. r=valentin,anti-tracking-reviewers,emz
https://github.com/mozilla-firefox/firefox/commit/efd9a5ba48fc
https://hg.mozilla.org/integration/autoland/rev/bb3b520f3751
Part 10: Store JSCallingLocation and set the JSCallingLocation fallback for Media loads. r=emilio

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a48b34690be0
https://hg.mozilla.org/integration/autoland/rev/aaf3b6d5fedf
Revert "Bug 1968644 - Part 10: Store JSCallingLocation and set the JSCallingLocation fallback for Media loads. r=emilio" for causing valgrid failures.

Comment 15

[agoloman]

Backed out for causing valgrid failures.

• Backout link
• Push with failures
• Failure Log

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8ed546cffea5
https://hg.mozilla.org/integration/autoland/rev/0add09725dbf
Part 1: Introduce triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags to LoadInfo. r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/2557f2f7087f
https://hg.mozilla.org/integration/autoland/rev/1feadec9e8ac
Part 2: Intorduce the ClassificationFlags to nsIClassifiedChannel.idl. r=dimi,necko-reviewers,valentin
https://github.com/mozilla-firefox/firefox/commit/7625948b4a14
https://hg.mozilla.org/integration/autoland/rev/fa205c13a9d3
Part 3: Populate the triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for fetch requests. r=valentin,smaug
https://github.com/mozilla-firefox/firefox/commit/464ccfa02087
https://hg.mozilla.org/integration/autoland/rev/b8034fc3b57f
Part 4: Populate triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for loads. r=smaug,necko-reviewers
https://github.com/mozilla-firefox/firefox/commit/8971015bb774
https://hg.mozilla.org/integration/autoland/rev/5241fe7b8fd1
Part 5: Populate triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for CSS loads. r=emilio
https://github.com/mozilla-firefox/firefox/commit/a2e385c45cf5
https://hg.mozilla.org/integration/autoland/rev/6bbfb39098a2
Part 6: Populate triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags during channel creation. r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/af47058de991
https://hg.mozilla.org/integration/autoland/rev/f8005c212eca
Part 7: Add tests. r=necko-reviewers,anti-tracking-reviewers,emz,valentin
https://github.com/mozilla-firefox/firefox/commit/1092aef20b9f
https://hg.mozilla.org/integration/autoland/rev/029ea08570fc
Part 8: Populate the triggeringFirstPartyClassificationFlags and triggeringThirdPartyClassificationFlags for WebSocket requests. r=valentin,necko-reviewers
https://github.com/mozilla-firefox/firefox/commit/a9140f7143bc
https://hg.mozilla.org/integration/autoland/rev/3828ace35535
Part 9: Add more tests for loads triggered by tracking scripts. r=valentin,anti-tracking-reviewers,emz
https://github.com/mozilla-firefox/firefox/commit/5d4a8a3770ca
https://hg.mozilla.org/integration/autoland/rev/aef1fda6be03
Part 10: Store JSCallingLocation and set the JSCallingLocation fallback for Media loads. r=emilio

Comment 17

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/0add09725dbf
https://hg.mozilla.org/mozilla-central/rev/1feadec9e8ac
https://hg.mozilla.org/mozilla-central/rev/fa205c13a9d3
https://hg.mozilla.org/mozilla-central/rev/b8034fc3b57f
https://hg.mozilla.org/mozilla-central/rev/5241fe7b8fd1
https://hg.mozilla.org/mozilla-central/rev/6bbfb39098a2
https://hg.mozilla.org/mozilla-central/rev/f8005c212eca
https://hg.mozilla.org/mozilla-central/rev/029ea08570fc
https://hg.mozilla.org/mozilla-central/rev/3828ace35535
https://hg.mozilla.org/mozilla-central/rev/aef1fda6be03