196892 - nsIEditor has XPCom method do, which is forbidden in javascript

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Pierre Baillet]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021226 Debian/1.2.1-9
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021226 Debian/1.2.1-9

nsIEditor.idl describes a do() method which cannot actually be used in javascript.
do() is a reserved keyword (see http://bugzilla.mozilla.org/show_bug.cgi?id=196836)

Reproducible: Always

Steps to Reproduce:



Expected Results:  
rename the do() in doTransaction() probably.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Um.. Editor bug.  ;)

This is blocking use of nsIEditor outside of C++.

Comment 2

[Pierre Baillet]

It's not really blocking:
You can use the  "transactionManager" attribute of the Editor and call
doTransaction on this object to get (i guess) the same result.

Comment 3

[Boris Zbarsky [:bzbarsky]]

180   /** do() fires a transaction.
181     * It is provided here so clients can create their own transactions.
182     * If a transaction manager is present, it is used.  
183     * Otherwise, the transaction is just executed directly.
184     *
185     * @param aTxn the transaction to execute
186     */

So you may not have a transaction manager....

Comment 4

[Judson Valeski]

minusing topembed as no known current embeddors are JS'ing nsIEditor. please
re-nominate if mistaken.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Well, they _can't_ very well JS using editor, since they would be unable to do
transactions.

Pierre, think you can write a patch for this?  ;)

Comment 6

[Joe Francis]

uh, Kin changed Do() to DoTransaction() some time ago, ya?  This is fixed already.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Um, yes.  It was fixed two months ago, a month after this bug was filed.  The
patch was on bug 192569.

Reopening to give this the right resolution...

Comment 8

[Boris Zbarsky [:bzbarsky]]

FIXED.