Closed
Bug 196895
Opened 22 years ago
Closed 22 years ago
nsJSContext::EvaluateString's use of aIsUndefined is inconsistent
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbradley, Assigned: jst)
Details
Attachments
(1 file)
|
583 bytes,
patch
|
jst
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
EvaluateString (version taking an const nsAString& has code that doesn't test
pointer aIsUndefined before assignment. The first assignment appears to be the
only one that does this. I think all cases should check. This check was added to
ExecuteScript with the same pattern.
|
Reporter | |
Comment 1•22 years ago
|
||
|
|
||
Comment 2•22 years ago
|
||
Comment on attachment 116860 [details] [diff] [review]
Adds the check of aIsUndefined
sr=alecf
Attachment #116860 -
Flags: superreview+
|
Assignee | |
Comment 3•22 years ago
|
||
Comment on attachment 116860 [details] [diff] [review]
Adds the check of aIsUndefined
r=jst, I'm checking this in now.
Attachment #116860 -
Flags: review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Fixed. Thanks for the patch! (I did some additional cleanup when checking this in).
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•