1968987 - Implement ToggleEvent.source

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Joey Arhar]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36

Steps to reproduce:

The ToggleEvent interface is getting a new "source" attribute added which is set to the element which triggered the toggling of the target element, such as a popover's invoker button: https://github.com/whatwg/html/pull/11186

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Keith Cirkel [:keithamus]]

Attachment: Bug 1968987 - Part 1 - Add Source to ToggleEvent, no longer generate. r?#dom-core,smaug

This takes the generated code of ToggleEvent and moves it into
dom/events, so that we can add the SetSource & GetSource members,
which set a Source RefPtr. This also requires us to add cycle collection
for mSource.

mSource is always retargeted against currentTarget just like
CommandEvent.

Comment 3

[Keith Cirkel [:keithamus]]

Attachment: Bug 1968987 - Part 2 - Set ToggleEvent source on Popover/Dialog r?#dom-core,smaug

This uses the implicit "invoker" from each element to set the
ToggleEvent Source, so that toggle events dispatched from Dialogs &
Popovers include the source attribute.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/89ee599ac8c3
https://hg.mozilla.org/integration/autoland/rev/6d4bc8443beb
Part 1 - Add Source to ToggleEvent, no longer generate. r=smaug,dom-core,webidl,saschanaz
https://github.com/mozilla-firefox/firefox/commit/f66dd32b15e6
https://hg.mozilla.org/integration/autoland/rev/f1bba678d327
Part 2 - Set ToggleEvent source on Popover/Dialog r=smaug,dom-core

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4dd97b58efff
https://hg.mozilla.org/integration/autoland/rev/b1f76add2c5b
Revert "Bug 1968987 - Part 2 - Set ToggleEvent source on Popover/Dialog r=smaug,dom-core" for causing build bustages @ ToggleEvent.cpp

Comment 6

[amarc]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log

Comment 7

[Cosmin Sabou [:CosminS]]

Also these wpts: https://treeherder.mozilla.org/logviewer?job_id=528112365&repo=autoland&task=MMj3cvHjRaqB0XpwydhEBg.0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d251e1c53cde
https://hg.mozilla.org/integration/autoland/rev/c69fbec7d9a1
Part 1 - Add Source to ToggleEvent, no longer generate. r=smaug,dom-core,webidl,saschanaz
https://github.com/mozilla-firefox/firefox/commit/abd05d12c3a9
https://hg.mozilla.org/integration/autoland/rev/b8895a1e2073
Part 2 - Set ToggleEvent source on Popover/Dialog r=smaug,dom-core
https://github.com/mozilla-firefox/firefox/commit/a9742e4fb6e9
https://hg.mozilla.org/integration/autoland/rev/ff133887b90c
apply code formatting via Lando

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/37b12c48c701
https://hg.mozilla.org/integration/autoland/rev/f3343aac5219
fix linting failure in details-toggle-source.html.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ecc18eebfd5
https://hg.mozilla.org/integration/autoland/rev/93d0472557e9
Revert "Bug 1968987 - fix linting failure in details-toggle-source.html." for causing wpt failures in details-toggle-source.html .

Comment 11

[Serban Stanca [:SerbanS]]

Reverted this because it was causing wpt failures in details-toggle-source.html .

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /html/semantics/interactive-elements/the-details-element/details-toggle-source.html | ToggleEvent.source on <details> elements: click details. - assert_true: An opening toggle event should have been fired. expected true got false

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7df5d3019b4f
https://hg.mozilla.org/integration/autoland/rev/a8633dfaf3fb
Part 1 - Add Source to ToggleEvent, no longer generate. r=smaug,dom-core,webidl,saschanaz
https://github.com/mozilla-firefox/firefox/commit/f322cfc77f39
https://hg.mozilla.org/integration/autoland/rev/32cbaae089de
Part 2 - Set ToggleEvent source on Popover/Dialog r=smaug,dom-core
https://github.com/mozilla-firefox/firefox/commit/4c94fd990e9f
https://hg.mozilla.org/integration/autoland/rev/58be1a8011b0
apply code formatting via Lando

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/654ef7406815
https://hg.mozilla.org/integration/autoland/rev/54b91e60b1c5
Revert "Bug 1968987: apply code formatting via Lando" for causing wpt failures @details-toggle-source.html.

Comment 14

[agoloman]

Backed out for causing wpt failures @details-toggle-source.html.

• Backout link
• Push with failures
• Failure Log

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5d3c32565550
https://hg.mozilla.org/integration/autoland/rev/2eacf57b65a4
Part 1 - Add Source to ToggleEvent, no longer generate. r=smaug,dom-core,webidl,saschanaz
https://github.com/mozilla-firefox/firefox/commit/90c4ed44a718
https://hg.mozilla.org/integration/autoland/rev/470c3081db4a
Part 2 - Set ToggleEvent source on Popover/Dialog r=smaug,dom-core
https://github.com/mozilla-firefox/firefox/commit/e1f5e5d7187a
https://hg.mozilla.org/integration/autoland/rev/850c85b7faf1
apply code formatting via Lando

Comment 16

[amarc]

https://hg.mozilla.org/mozilla-central/rev/2eacf57b65a4
https://hg.mozilla.org/mozilla-central/rev/470c3081db4a
https://hg.mozilla.org/mozilla-central/rev/850c85b7faf1

Comment 17

[Hamish Willee]

FF145 MDN work for this can be tracked in https://github.com/mdn/content/issues/41543