196903 - Create aix.js for AIX specific preferences

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Philip K. Warren]

For AIX, we require our own preferences file to override some of the default
settings in unix.js. In particular, we would like to override some of the
default font settings for the browser to use fonts which exist on AIX.

Comment 1

[Roland Mainz]

Nice idea... can we extend this to include a "solaris.js" for Solaris,
"hp-ux.js" for HP-UX, "osf1.js" for OSF/1 etc. ?

Comment 2

[Conrad Carlen (not reading bugmail)]

Sure. File separate bugs as the need is identified, though. And, they should be
assigned to those who build on those platforms - as well as this one. I really
can't do anything with it.

Comment 3

[Conrad Carlen (not reading bugmail)]

BTW, on http://www.mozilla.org/owners.html, it would be good to have the "owner"
of ports platforms. I'd like to find an AIX person to give this to. Is there
somewhere to find this info in one place?

Comment 4

[Philip K. Warren]

Taking ownership of bug.

Comment 5

[Philip K. Warren]

Attachment: Patch v1

Comment 6

[Conrad Carlen (not reading bugmail)]

Comment on attachment 117244 [details] [diff] [review]
Patch v1

>Index: modules/libpref/src/nsPrefService.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/modules/libpref/src/nsPrefService.cpp,v
>retrieving revision 1.64
>diff -u -r1.64 nsPrefService.cpp
>--- modules/libpref/src/nsPrefService.cpp	12 Mar 2003 00:39:31 -0000	1.64
>+++ modules/libpref/src/nsPrefService.cpp	14 Mar 2003 21:20:31 -0000
>@@ -535,6 +535,8 @@
>       "unix.js"
> #if defined(VMS)
>       , "openvms.js"
>+#elif defined(_AIX)
>+      , "aix.js"
> #endif
> #if defined(MOZ_WIDGET_PHOTON)
> 	  , "photon.js"

r=ccarlen.

For something to clean up someday: Instead of having to edit nsPrefService.cpp
when adding a new variant, maybe the makefile could #define PLATFORM_PREFS?

Comment 7

[Alec Flett]

Or even better, there should be a "platform.js" foreach platform, and prefs
would just load that one last.

Comment 8

[Alec Flett]

Comment on attachment 117244 [details] [diff] [review]
Patch v1

sr=alecf by the way.. man I don't like this :)

Comment 9

[Philip K. Warren]

Fixed.

Checking in Makefile.in;
/cvsroot/mozilla/modules/libpref/src/Makefile.in,v  <--  Makefile.in
new revision: 1.68; previous revision: 1.67
done
Checking in nsPrefService.cpp;
/cvsroot/mozilla/modules/libpref/src/nsPrefService.cpp,v  <--  nsPrefService.cpp
new revision: 1.65; previous revision: 1.64
done
RCS file: /cvsroot/mozilla/modules/libpref/src/unix/aix.js,v
done
Checking in unix/aix.js;
/cvsroot/mozilla/modules/libpref/src/unix/aix.js,v  <--  aix.js
initial revision: 1.1
done