Last Comment Bug 196919 - mLastFloaterY doesn't enforce that float can't be above earlier float
: mLastFloaterY doesn't enforce that float can't be above earlier float
Status: RESOLVED FIXED
[patch]
:
Product: Core
Classification: Components
Component: Layout: Floats (show other bugs)
: Trunk
: All All
: P1 major (vote)
: mozilla1.4alpha
Assigned To: David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch)
: Hixie (not reading bugmail)
Mentors:
Depends on:
Blocks: 177331
  Show dependency treegraph
 
Reported: 2003-03-11 12:01 PST by David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch)
Modified: 2003-03-11 15:58 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (892 bytes, text/html)
2003-03-11 12:01 PST, David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch)
no flags Details
patch (18.29 KB, patch)
2003-03-11 12:46 PST, David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch)
roc: review+
roc: superreview+
Details | Diff | Splinter Review
patch with removal instead of #if 0 (21.83 KB, patch)
2003-03-11 14:15 PST, David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch)
roc: review+
roc: superreview+
Details | Diff | Splinter Review

Description David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2003-03-11 12:01:01 PST
nsBlockReflowState::mLastFloaterY isn't sufficient to enforce that a float can't
be above an earlier float.  I'll attach a testcase to show this.  It needs to be
on the space manager.
Comment 1 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2003-03-11 12:01:40 PST
Created attachment 116872 [details]
testcase
Comment 2 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2003-03-11 12:46:12 PST
Created attachment 116876 [details] [diff] [review]
patch

This fixes this bug and bug 177331.
Comment 3 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2003-03-11 12:49:59 PST
Note that this patch also includes the patch for bug 115153, simply because I
haven't checked it in yet.
Comment 4 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2003-03-11 12:57:09 PST
Comment on attachment 116876 [details] [diff] [review]
patch

I dislike #if 0. Is there a good reason to leave this in?
Comment 5 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2003-03-11 13:01:01 PST
I'm not really sure.  nsSpaceManager was originally written to be rather
general, and I've already polluted it with a good bit of
block-specific/float-specific stuff, but I think it really needs to go more in
that direction (see bug 191448) and, furthermore, that we're unlikely to need
the code for anything other than floats.  So I guess I'm inclined to just remove
it if you like that idea as well.  (cc:ing kin if he wants to chime in as well.)
Comment 6 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2003-03-11 13:12:40 PST
I can't think of anything that we're going to need "space management" for beyond
floats, at least for the forseeable future. (I can imagine at some point we
might want support for positioned elements that siblings flow around, but you
can't even do that in CSS3 ... right?)

Even if we could forsee a potential broader use, it's probably better to get
floats working well and then figure out how to extend the code later.
Comment 7 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2003-03-11 14:15:32 PST
Created attachment 116883 [details] [diff] [review]
patch with removal instead of #if 0
Comment 8 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2003-03-11 15:07:00 PST
Ran the regression tests.  Saw only noise.  Will add attachment 116872 [details] to the
block/bugs regression tests.
Comment 9 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2003-03-11 15:58:55 PST
Fix checked in to trunk, 2003-03-11 15:56 PST.

Note You need to log in before you can comment on or make changes to this bug.