197260 - Wrong image for the "Phoenix" theme in the Options

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Pham]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030310 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030310 Phoenix/0.5

The theme Phoenix(qute) is displayed incorrectly. Tools>Options>Themes>Phoenix
has a screenshot of Classic

Reproducible: Always

Steps to Reproduce:

Comment 1

[Simon Paquet [:sipaq]]

Confirming. Setting dependency to bug 189043.

Comment 2

[Sébastien Delahaye]

OS -> All.

Comment 3

[Pham]

Attachment: screenshot

This is probably back to 0.5 and back.

Comment 4

[noririty]

Attachment: proposed patch

I think the problem is mismatch of preview image.

Comment 5

[noririty]

Attachment: example image

Current virsion of "Preview.png"(Rev1.3) size is 375x40.
Preview images should be 355x85 or the images would be terribly resized.
This is an example of 355x85 default Qute image.

Comment 6

[Sébastien Delahaye]

Reassigning to Arvid.

Comment 7

[Chris Cook]

The existing image (preview.gif) should be replaced instead of updating code to
use the new png as it is significantly larger for no reason.

Additionally, this bug should be re-assigned to someone who can replace the
image as I don't believe Arvid has cvs rights, unless this has changed.

Also recommend making this bug a blocker for 0.6 since this is the first
milestone with this theme and it will be confusing otherwise.

Comment 8

[Chris Cook]

Attachment: Alternate preview gif

Attaching an alternate preview image that doesn't use the WinXp Luna theme to
potentially confuse things.

Comment 9

[Chris Cook]

Also, "\skin\classic\global\Preview.png" should be deleted to reduce space. This
should go in bug 189043 but perhaps it will be done at the same time.

Comment 10

[dmoran]

Chris, referring to:

http://bugzilla.mozilla.org/attachment.cgi?id=121388&action=view

Might be an idea to update the bookmarks from "Phoenix Help" and "Phoenix
Discussions" to "Firebird Help" & "Firebird Discussions".

Comment 11

[Pham]

Attachment: another option

This one uses big icons, which are more attractive. It also has a white
background, which resembles Luna but it's really Classic. I also used cnn.com
instead of mozilla.org in the location bar because I'm sure most who download
Firebird care more about browsing then testing. It's also free advertising to
CNN>AOLTimeWarner which is a major sponsor of mozilla.org

Comment 12

[Pham]

I prefer http://bugzilla.mozilla.org/attachment.cgi?id=117817&action=view or
http://bugzilla.mozilla.org/attachment.cgi?id=121460&action=view 

Comment 13

[Chris Cook]

Attachment: Classic with large icons and renamed bookmarks

Point taken about the old bookmarks. Here is another graphic with renamed
bookmarks and large icons.

Alternate websites and colors may look nice to some, but the theme preview
should present as "default" a view as possible.

Comment 14

[Pham]

Maybe it should be with the luna theme because qute is based on Luna(the new
window/the back/forward, the history icon...)

Comment 15

[Pham]

Attachment: luna for qute's lunaness

Comment 16

[Chris Cook]

The graphics may be based on a WinXP theme but that does not justify presenting
a specific (and very distinctive) OS theme in the theme preview that increases
the potential for confusion about what the theme will actually look like with
other OS themes, IMHO.

Comment 17

[Robert Parenton]

I suggest that http://bugzilla.mozilla.org/attachment.cgi?id=121487&action=view
replace the following files:

/mozilla/themes/classic/global/mac/preview.gif
/mozilla/themes/classic/global/win/preview.gif

It also seems that /mozilla/toolkit/skin/win/Preview.png is not needed and
should be removed.

Also, it would be nice to get this one into 0.6 as the preview image is
misleading right now, and IMO, that is inappropriate for a milestone.

Comment 18

[Robert Parenton]

Attachment: Patch allowing removal of unused /toolkit/skin/win/Preview.png

Comment 19

[Robert Parenton]

Here is a working patch/solution:

replace these files with
http://bugzilla.mozilla.org/attachment.cgi?id=121487&action=view
  mozilla/themes/classic/global/mac/preview.gif
  mozilla/themes/classic/global/win/preview.gif

apply Patch allowing removal of unused mozilla/toolkit/skin/win/Preview.png (
http://bugzilla.mozilla.org/attachment.cgi?id=123314&action=view )

delete mozilla/toolkit/skin/win/Preview.png

After following the above steps, I built and tested Firebird on Windows and
Linux.  The above method solved the problem perfectly on both platforms.

*** Asa, I think we should get this into 0.6 as it could be confusing to new
users.  It shouldn't be too hard, as the patch is minor and would take no more
than a few min to review and checkin.  Can you set this to 0.6 so it doesn't get
missed. ***

Comment 20

[Robert Parenton]

Comment on attachment 123314 [details] [diff] [review]
Patch allowing removal of unused /toolkit/skin/win/Preview.png

Requesting review of patch (and preview.gif) replacement from bryner.  Please
see Comment #19 for description/instructions.

Comment 21

[Brian Ryner (not reading)]

No, we shouldn't replace the preview.gif files in mozilla/themes/classic; those
should still be a preview of the seamonkey classic skin.

Comment 22

[Brian Ryner (not reading)]

I checked in a fix for this using the luna image of qute.  It's a matter of
personal opinion, but I think this is the best looking of the screenshots.

Comment 23

[Vedran Miletic]

This Qute image is a bit out of date (Qute uses different stop button now).
I rescreenshoted using both Luna and Classic windows theme.

Comment 24

[Vedran Miletic]

Attachment: This is new Qute with Classic theme

This is just an example (size is too big, so the required part can be simply
cut from this image if needed)

Comment 25

[Vedran Miletic]

Attachment: This is new Qute with Luna theme

Same thing, just with Luna theme.

Comment 26

[Pham]

Attachment: luna/newQute

how about this?

Comment 27

[Vedran Miletic]

#26:
Not bad, except quality :)

I would personally prefer to have text labels, but developers will make final
decision.

Comment 28

[Brian Ryner (not reading)]

I checked in attachment 123708 [details] cropped to the size we had before (355x85).

Comment 29

[Michael Newton]

i notice we took out the "classic" theme preview, but in addition to taking out
the image, should all reference to the mozilla theme not be removed?  it can't
be selected as your theme, so it's just going to confuse anyone who might want
that theme.  can't think who would, though!  please advise if this should be a
seperate bug.

Comment 30

[Tom Sommer]

I think you are talking about bug 191992 :)

Comment 31

[Simon Paquet [:sipaq]]

Verified.