Closed Bug 1972757 Opened 8 months ago Closed 8 months ago

Store cookie expiry value as msec

Categories

(Core :: Networking: Cookies, task, P2)

Product:
Core
Component:
Networking: Cookies
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
142 Branch
Tracking Flags:
Tracking Status
firefox142 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

(Whiteboard: [necko-triaged], [wptsync upstream])

Attachments

(1 file)

Bug 1972757 - Store cookie expiry value as msec, r?valentin
48 bytes, text/x-phabricator-request
Details | Review

CookieStore uses DOMHighResTimeStamp for the expires attribute. Currently, we cast the value to seconds, but it would be better to use milliseconds everywhere to keep the original values, as received at the cookie creation time.

Severity: -- → N/A
Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by amarchesini@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f1207c11450f https://hg.mozilla.org/integration/autoland/rev/6d1a43dbd631 Store cookie expiry value as msec, r=valentin,webdriver-reviewers,extension-reviewers,search-reviewers,devtools-reviewers,cookie-reviewers,migration-reviewers,backup-reviewers,scunnane,whimboo,robwu,ochameau,kpatenio

Backed out for causing Marionette failures @ test_moved_origin_directory_cleanup.py

Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1958a03842f1 https://hg.mozilla.org/integration/autoland/rev/0fa3fd9ebefc Store cookie expiry value as msec, r=valentin,webdriver-reviewers,extension-reviewers,search-reviewers,devtools-reviewers,cookie-reviewers,migration-reviewers,backup-reviewers,scunnane,whimboo,robwu,ochameau,kpatenio

https://hg.mozilla.org/mozilla-central/rev/6d1a43dbd631

Status: NEW → RESOLVED
Closed: 8 months ago
status-firefox142: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch

Backed out for causing wpt failures @ cookies/attributes/max-age.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/394404d0c0445d1f38a77c6ac7c38fb8f0ace796

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | /cookies/attributes/max-age.html

Status: RESOLVED → REOPENED
status-firefox142: fixed → ---
Flags: needinfo?(amarchesini)
Resolution: FIXED → ---
Target Milestone: 142 Branch → ---

https://hg.mozilla.org/mozilla-central/rev/0fa3fd9ebefc

Status: REOPENED → RESOLVED
Closed: 8 months ago → 8 months ago
status-firefox142: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5869af852cd2 https://hg.mozilla.org/integration/autoland/rev/cf29824684a5 Store cookie expiry value as msec, r=valentin,webdriver-reviewers,extension-reviewers,search-reviewers,devtools-reviewers,cookie-reviewers,migration-reviewers,backup-reviewers,scunnane,whimboo,robwu,ochameau,kpatenio https://github.com/mozilla-firefox/firefox/commit/37be419168b7 https://hg.mozilla.org/integration/autoland/rev/3ed42ff99719 1973024: apply code formatting via Lando
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/53367 for changes under testing/web-platform/tests
Whiteboard: [necko-triaged] → [necko-triaged], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
Upstream PR merged by moz-wptsync-bot
QA Whiteboard: [qa-triage-done-c143/b142]
See Also: → 1986688
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: