[patch]Turn on Automatic image resizing in Camino

VERIFIED FIXED in Camino0.8

Status

Camino Graveyard
General
--
enhancement
VERIFIED FIXED
15 years ago
14 years ago

People

(Reporter: Chris Petersen, Assigned: Mike Pinkerton (not reading bugmail))

Tracking

unspecified
Camino0.8
PowerPC
Mac OS X

Details

Attachments

(1 attachment)

517 bytes, patch
Mike Pinkerton (not reading bugmail)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

15 years ago
This is a helpful way to view a large image in the browser. Image scales to the
fit inside the window if image is larger that current window. This feature can
be enabled (on or off) in the contextual menu.

Comment 1

15 years ago
Only if added to the prefs panel, please.
(Assignee)

Comment 2

14 years ago
mmmmm maybe. the firebird guys don't really like it, i'm torn about it. i just
know as soon as we don't do it, safari will and we'll have to :)
Assignee: saari → pinkerton
Target Milestone: --- → Camino0.8

Comment 3

14 years ago
I'll revise my statement (and then exit this discussion)...

I don't think it should be in unless it does the "alert on first popup" sort of
thing. First time camino wants to resize an image in this way it pops up a
message saying what it is trying to do and asks you how you want the pref set. I
think that's about the only way you're gonna make close to 'everyone' happy and
has the added benefit of helping people discover the feature and praise
it/Camino if they like it.

Here tho, it'll stay off.

Comment 4

14 years ago
I think this is a very nice feature which we can live without, but as it's ready
for implementation and handy for those users that don't have a huge 19' display
like I do, why not implement it anayway.

I don't agree that a sheet asking this would be the thing to do. If you asked me
I would just ad a pref line in the WebFeatures section.

Perhaps adding a menu item to the Application main menu (as Safaro does for
popups), making it easy to turn on and of and adding a key combination would
give the users the most flexability.

Comment 5

14 years ago
Just added this line (user_pref("browser.enable_automatic_image_resizing",
true);) to test out image resizng in Camino and almost everything seems to work
fine for one thing. 

The spyglass cursor does not seem to update unless you move your mouse! I double
checked with Mozilla 1.5b and it seems it has the same issue.

Comment 6

14 years ago
Bug 195045 should be tracked to have that bug fixed.
Created attachment 133639 [details] [diff] [review]
turn automatic resizing on.
Comment on attachment 133639 [details] [diff] [review]
turn automatic resizing on.

An easy one line patch
Attachment #133639 - Flags: review?
updateing summary.
Summary: Turn on Automatic image resizing in Camino → [patch]Turn on Automatic image resizing in Camino
(Assignee)

Comment 10

14 years ago
landed. we'll give it a try and see what the user feedback is. for those who
really hate it, you can turn it off in your local prefs.js
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Assignee)

Updated

14 years ago
Attachment #133639 - Flags: review? → review+
(Reporter)

Comment 11

14 years ago
Verified that automatic image resizing is enabled by default now. Tested with
the 2003102211 NB.
Status: RESOLVED → VERIFIED

Comment 12

14 years ago
Image resizing worked at first, but seems to be broken in Build ID: 2003110516
on OS 10.3.0.  Here's a 1600x1200 testcase:

http://mandolux.mine.nu/desktops/aa-desktops-images/a-asiana/mandolux-asiana-03-1600.jpg
(Assignee)

Comment 13

14 years ago
yeah, i noticed that. it works if you put it in your prefs.js, but doesn't work
from all-camino.js. I wonder if we're not picking that file up anymore since the
switch to the new GRE style.

dougt, could being an "old style" embedding app affect our loading of all-*.js
pref files?

Comment 14

14 years ago
it might.  how is all-camino.js loaded?  Is it relative to some directory
service known location?
You need to log in before you can comment on or make changes to this bug.